Skip to content

OBEE-6 Document type for (tabular) instances - #1332

Merged
tim-at-topos merged 4 commits into
mainfrom
tim/instance-document-type
Aug 4, 2026
Merged

OBEE-6 Document type for (tabular) instances#1332
tim-at-topos merged 4 commits into
mainfrom
tim/instance-document-type

Conversation

@tim-at-topos

@tim-at-topos tim-at-topos commented Jun 30, 2026 •
edited
Loading

Copy link
Copy Markdown
Contributor

To-do:

  • write a backend integration test

@github-actions

github-actions Bot commented Jun 30, 2026

Copy link
Copy Markdown

Notion Integration

@tim-at-topos
tim-at-topos force-pushed the tim/instance-document-type branch from 358cf80 to ed74638 Compare July 8, 2026 20:03
@tim-at-topos
tim-at-topos requested a review from kasbah July 9, 2026 10:20
@tim-at-topos
tim-at-topos force-pushed the tim/instance-document-type branch from 8bf6100 to d166030 Compare July 9, 2026 10:44
@kasbah

kasbah commented Jul 15, 2026

Copy link
Copy Markdown
Member

I pushed a commit removing the fake instance editor from frontend.

kasbah
kasbah reviewed Jul 15, 2026
View reviewed changes
Comment thread packages/document-types/src/v2/document.rs Outdated
Comment thread packages/document-types/src/v2/instance.rs Outdated
kasbah
kasbah reviewed Jul 15, 2026
View reviewed changes
Comment thread packages/document-types/src/v2/instance.rs Outdated
kasbah
kasbah reviewed Jul 15, 2026
View reviewed changes
Comment thread packages/document-types/src/v2/instance.rs Outdated
@tim-at-topos
tim-at-topos marked this pull request as ready for review July 21, 2026 12:47
@tim-at-topos
tim-at-topos requested a review from kasbah July 21, 2026 13:25
@tim-at-topos
tim-at-topos marked this pull request as draft July 22, 2026 17:30
@tim-at-topos
tim-at-topos force-pushed the tim/instance-document-type branch 3 times, most recently from 94ae714 to 33ac052 Compare July 23, 2026 10:48
@tim-at-topos
tim-at-topos marked this pull request as ready for review July 23, 2026 11:36
@tim-at-topos
tim-at-topos force-pushed the tim/instance-document-type branch from a01de7d to 9f3c52a Compare July 23, 2026 11:48
@epatters epatters added enhancement New feature or request frontend TypeScript frontend and Rust-wasm integrations labels Jul 26, 2026
epatters
epatters requested changes Jul 26, 2026
View reviewed changes

@epatters epatters left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, this is shaping up! Some comments, mostly minor, below.

Comment thread packages/document-types/src/v2/document.rs Outdated
Comment thread packages/ui-components/src/document_type_icon.tsx Outdated
Comment thread packages/document-types/src/v2/document.rs
Comment thread packages/document-types/src/v2/instance.rs Outdated
Comment thread packages/document-types/src/v2/instance.rs Outdated
Comment thread packages/document-types/src/v2/document.rs Outdated
Comment thread packages/document-types/src/v2/instance.rs Outdated
Comment thread packages/document-types/src/v2/instance.rs Outdated
@tim-at-topos
tim-at-topos force-pushed the tim/instance-document-type branch 6 times, most recently from 0640a78 to abba869 Compare July 31, 2026 12:12
@tim-at-topos
WIP: document-types/instance.rs
241993a 
First suggestion of instances document type

WIP: fix CI

WIP: Lots of frontend faff

WIP: Whatever is needed to pass tests

null

UUID

WIP: Remove fake tabular instance editor from frontend

WIP: Remove f32 so we can derive Eq

WIP: restore f32, remove Eq, remove instance_judgment

WIP: fix frontend type narrowing confused by instance

small change to comment wording

ENH: Backend test

FIX: DocumentType

FIX: .clone()

FIX: this???

FIX: fix?

FIX: FIX?!

FIX: Half of Evan's comments

FIX: Add rust lints to document-types

FIX: Some comments

FIX: Yet more comments

FIX: Remove linting (for now)
@tim-at-topos
tim-at-topos force-pushed the tim/instance-document-type branch 2 times, most recently from 8c45c78 to 83f99ac Compare July 31, 2026 12:26
@tim-at-topos
tim-at-topos force-pushed the tim/instance-document-type branch from b08236c to a9cc8db Compare July 31, 2026 17:35
@tim-at-topos
tim-at-topos requested a review from epatters July 31, 2026 18:06
@epatters
epatters force-pushed the tim/instance-document-type branch from f1a9389 to 80dcc73 Compare July 31, 2026 18:55
epatters
epatters approved these changes Jul 31, 2026
View reviewed changes

@epatters epatters left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is looking good!

I will approve as is and leave it for @kasbah to decide, when he gets back, whether to address the document type duplication as part of this PR or in the future. In the latter case I would prefer that we create an issue to track this so we don't have the same conversation every time we add a new document type.

@kasbah kasbah mentioned this pull request Aug 4, 2026
Open
@tim-at-topos
tim-at-topos force-pushed the tim/instance-document-type branch from 892730b to 80dcc73 Compare August 4, 2026 16:29
@tim-at-topos

tim-at-topos commented Aug 4, 2026

Copy link
Copy Markdown
Contributor Author

We've opened #1369 and #1370 to track these two reduplications.

@tim-at-topos
tim-at-topos merged commit 829bc8a into main Aug 4, 2026
37 checks passed
@tim-at-topos
tim-at-topos deleted the tim/instance-document-type branch August 4, 2026 16:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@epatters epatters epatters approved these changes
@kasbah kasbah Awaiting requested review from kasbah

Assignees

No one assigned

Labels

enhancement New feature or request frontend TypeScript frontend and Rust-wasm integrations

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@tim-at-topos @kasbah @epatters