Skip to content

syscall: let secure_relative_open() fallback create a missing final component #1034

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
mabunemeh wants to merge 1 commit into
base: master
Choose a base branch
from
+9 −0
Open

syscall: let secure_relative_open() fallback create a missing final component #1034

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 9 additions & 0 deletions syscall.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1995,6 +1995,15 @@ int secure_relative_open(const char *basedir, const char *relpath, int flags, mo
goto cleanup;
}
if (next_fd == -1) {
/* Final component that does not exist yet: if the caller
* wants a file (not O_DIRECTORY), open/create it here with
* O_NOFOLLOW so O_CREAT works and a pre-planted symlink at
* the name is still refused. A missing *intermediate*
* component (more path follows) stays a genuine ENOENT. */
if (errno == ENOENT && !(flags & O_DIRECTORY)
&& strtok(NULL, "/") == NULL) {
retfd = openat(dirfd, part, flags | O_NOFOLLOW, mode);
}
goto cleanup;
}
if (dirfd != AT_FDCWD) close(dirfd);
Expand Down