feat(sdk): regen — measured graph storage replaces the size estimate - #148
Merged
Conversation
BREAKING for get_graph_metrics callers.
GraphMetricsResponse.estimated_size -> storage. The server no longer
guesses storage from node count (robosystems#938); it reports the
measured on-disk total plus an itemized breakdown, so the old field name
would have kept implying an estimate that no longer exists.
estimated_size was a required field parsed with d.pop(), so 0.5.8 raises
KeyError against a server that has deployed #938. Callers of
get_graph_metrics must move to this release; nothing else is affected.
GraphMetricsResponseEstimatedSize -> GraphMetricsResponseStorage
(total_bytes/kb/mb/gb + items)
Also catches up on robosystems#937's storage work, which landed after the
0.5.8 regen: InstanceUsage gains `items`, and the new StorageItem model
carries the per-type breakdown — graph, memory, subgraph, vectors,
staging.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Regenerates against robosystems#938, which replaces a
node_count * 100 bytesstorage guess with the measured on-disk total.Warning
Breaking for
get_graph_metricscallers, and it fails loudly.estimated_sizewas a required field parsed withd.pop("estimated_size"), so 0.5.8 raisesKeyErroragainst a server that has deployed #938. Callers ofget_graph_metricsmust move to this release. Nothing else in the SDK is affected.Important
Merge and publish alongside the robosystems#938 deploy. The goal is to keep the window short where prod returns
storagebut the newest published client demandsestimated_size.Changes
GraphMetricsResponse.estimated_size→storageGraphMetricsResponseEstimatedSizeGraphMetricsResponseStorageestimated_bytes/estimated_kb/estimated_mb,method,notetotal_bytes/total_kb/total_mb/total_gb,itemsThe rename is not cosmetic: the server stopped estimating, so a field called
estimated_sizewould have kept implying something that no longer happens. The value now spans the graph, its memory database, subgraphs, vector indexes and staging file.An unreachable instance returns
{"error": ...}with no total, rather than a fallback estimate.Upstream catch-up — robosystems#937 storage work that landed after the 0.5.8 regen:
InstanceUsagegainsitemsStorageItemmodel — per-type breakdown across graph, memory, subgraph, vectors, stagingTesting
just test-all— ruff check, ruff format, basedpyright 0 errors, 439 passed / 17 skipped: all green.Pure regen output — no hand edits. Version bump / release handled separately by the publish flow.