perf: skip trivial 1-raw-sig + 0-children case during aggregation - #1469
Merged
Conversation
rupam-04
requested review from
Kayden-ML,
KolbyML and
shariqnaiyer
as code owners
June 25, 2026 22:39
shariqnaiyer
approved these changes
Jun 26, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What was wrong?
Closes #1465
How was it fixed?
Minor fix as mentioned in leanEthereum/leanSpec#748. Adds new test
test_aggregate_skips_single_gossip_sig_with_no_childrenandtest_multiple_attestation_data_grouped_separatelywas also modified since the former implementation would produce no proof nowTo-Do