Use swift-embedded-foundation instead of Foundation shims#25
Merged
Conversation
Code Coverage OverviewLanguages: Swift Swift / code-coverage/llvm-covThe overall coverage remains at 96%, unchanged from the Code Coverage is in Public Preview. Learn more and provide us with your feedback. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Replaces the hand-rolled Foundation shims (
Data,UUID,Date,Decimal,URL, ~700 lines) with the swift-embedded-foundation package for Foundation-free (Embedded Swift) builds.Package.swiftadds theFoundationEmbeddeddependency behind aSWIFT_EMBEDDED=1environment gate, since its deployment-target minimums are higher than CoreModel's and regular builds use Foundation/FoundationEssentials anywayFoundationShims.swiftthat re-exports theFoundationEmbeddedtypes viapublic typealiasunder#if !canImport(FoundationEssentials) && !canImport(Foundation)ObjectID.swiftandPredicate/Expression.swiftgain#elseif canImport(FoundationEmbedded)import branches, required because Embedded Swift needs a per-file import for cross-module member accessSWIFT_EMBEDDED=1Testing
swift buildandswift teston macOS: 22/22 tests passswift-6.3.3-RELEASE_wasm-embeddedSDK) withSWIFT_EMBEDDED=1 SWIFTPM_ENABLE_MACROS=0, debug and release: builds clean