Conversation
… from the release-master release.
|
@jemarq04 @FallenDeity I'm gonna merge this PR soon. I just wanted to tell you that when you will pull the changes to your local machine you will need to spin up a fresh pokeapi instance if you're using docker. Because I bumped the postgres DB version. If you want to comment on the PR as well it's more than welcome. The aim is to deploy faster the GQL service on our small machine without building the DB on the machine but rather using a dump generated by the CICD pipeline. |
| docker compose ${gql_compose_config} stop web graphql-engine app cache | ||
| docker compose ${gql_compose_config} down -v db | ||
| docker compose ${gql_compose_config} up --pull always -d db | ||
| sleep 10 |
There was a problem hiding this comment.
instead of arbitrary sleep wouldn't it be better to check container status
There was a problem hiding this comment.
Yeah, but I don't want it to be so complicated.
There was a problem hiding this comment.
I was thinking something like this
its still a one liner and kind of a simple do while loop, its more reliable too if for any reason it takes up more than the sleep alotted time
@until docker compose ${gql_compose_config} exec -T db pg_isready -U ash -d pokeapi; do sleep 1; done
similarly for the other sleep too
| update-graphql-data-prod: | ||
| git pull origin master | ||
| git submodule update --remote --merge | ||
| curl -Ss -L -O https://github.com/PokeAPI/pokeapi/releases/download/master-branch/pokeapi.pgdump |
There was a problem hiding this comment.
just an idea but would it be possible to stream or pipe the curl directly to pg restore over reading/writing to disk
2 participants
Change description
Postgres was updated to 18 from 17, and this requires a different mount point for its data. It's also required to wipe the current volume and rebuild everything. No migration will be provided.
AI coding assistance disclosure
Contributor check list