Migrate to Parcels v4 - #342
Draft
j-atkins wants to merge 62 commits into
Draft
Conversation
…ument column entries are consistent
for more information, see https://pre-commit.ci
j-atkins
force-pushed
the
update-docs-sensors
branch
from
May 21, 2026 08:24
f474279 to
0fe1340
Compare
This reverts commit 003f79f.
Collaborator
Author
|
Hi @erikvansebille and @VeckoTheGecko, here's the latest draft of VirtualShip migration to Parcels v4 (still a WIP though). No need to review properly at this point, it's for your reference in case you are curious whilst I'm away over the next couple of weeks! |
* small refactor: consolidate spacetime_buffer_size and limit_spec dicts for clarity * to FetchSpec dataclass * new test for FetchSpec class
* add tmp file write/read step * small refactor: consolidate spacetime_buffer_size and limit_spec dicts for clarity * to FetchSpec dataclass * add tmp file write/read step * remove depth axis reversal now using depth='elevation' in copernicusmarine.open_dataset() * tidy up todo * small update: fetch spec to match changes implemented in #359 * add test for _via_tmp_ds * add to_windowed_arrays() back in
* instrument type property, conditional windowed arrays * add instrument_type/is_underway property tests to ADCP instrument tests * update tests across all instruments for instrument type property/is underway, incl. some refactoring * clean-up for review * Apply suggestions from code review Co-authored-by: Erik van Sebille <e.vansebille@uu.nl> --------- Co-authored-by: Erik van Sebille <e.vansebille@uu.nl>
Closed
* first changes; Parcels v4 API * move to using field.eval for UV sampling, plus call to custom write-to-parquet * custom write-to-parquet for underway instruments * instrument type property, conditional windowed arrays * tidy up * sample individual U and V fields for m s-1 units * fix u, v sampling to use correct sampling and conversions * new intermediate UnderwayInstrument base class (parquet writing moved over from utils), change kernels to special-case underway kernels * fix intermediate class logic so that sensor_kernels check is only triggered for final instrument child classes * remove support for depth as None * use coords for adcp 'kernel' * add validtion to UnderwayCoordinates class, rename func * migrate UnderwaterST instrument to new underway instrument logic * fix func name * add new tests and refine for intermediate UnderwayInstrument class * update ADCP tests * tidy up comments * update UnderwaterST tests * use fieldset.time_interval.left / right for fieldset start / end times * particle_id is constant for underway instruments * dt and state are unnecessary for public facing output * add test for monitoring for schema drift vs. parcels, plus some refactoring * Update tests/instruments/test_base.py Co-authored-by: Erik van Sebille <erikvansebille@gmail.com> * remove dev spinner bypass option * parcels simulation only needs one write step --------- Co-authored-by: Erik van Sebille <erikvansebille@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
WIP
Checklist/current status:
Argo float bug [in kernel(s)?], immediately goes out of bounds after first timestep... likely depth convention related.zarroutput) [new PR?]