-
Notifications
You must be signed in to change notification settings - Fork 509
fix(python): import converters and specs lazily so inference does not load torch #2080
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
Anai-Guo
wants to merge
3
commits into
OpenNMT:master
Choose a base branch
from
Anai-Guo:fix-lazy-converter-imports
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
+72
−1
Open
Changes from all commits
Commits
Show all changes
3 commits
Select commit
Hold shift + click to select a range
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for your work
Could we add a small regression test for
from ctranslate2 import *?Before this change, wildcard imports exposed
convertersandspecs. Since wildcard import uses__all__if defined, otherwise current module globals, it would be good to check that this behavior is still preserved with the lazy imports.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good call — writing the test turned up an actual regression rather than confirming the behavior.
Wildcard imports read
__all__when it is defined and fall back to the module globals otherwise.convertersandspecswere previously plain globals, sofrom ctranslate2 import *bound them. Once they moved behind the module__getattr__they were no longer in the globals, and CPython'simport *does not consult__getattr__or__dir__— so they silently dropped out of the wildcard surface.__dir__alone was not enough.Confirmed on 3.14 with a reduced repro:
Fixed by deriving
__all__at the end of__init__.py:Deriving it rather than hardcoding a list keeps two things intact: the wildcard surface stays byte-for-byte what it was before the submodules became lazy, and installs without the compiled extension still work (those names are simply absent from the globals, exactly as before). A wildcard import asks for everything, so resolving the lazy submodules at that point is the expected cost — plain
import ctranslate2stays free of torch/transformers, which the existing test still covers.Added
test_wildcard_import_still_exposes_lazy_submodulesfor this. It runs in a subprocess so the wildcard import does not leak into the session, and it is guarded withpytest.importorskip("transformers")sinceconvertersimports transformers and the test requirements only install it on Linux. I verified it fails ([]) without the__all__change and passes (['converters', 'specs']) with it.black and flake8 (
max-line-length=100) are clean on both files.