Allow board layer matching without a selected device#2533
Conversation
Skip comparing the layer's for-device name when the current context does not specify a device. This supports layer discovery where only the board is known while preserving vendor and processor checks when available. Update the unit test to expect successful matching for a board-only context with a device-name constraint.
aa22450 to
a8fa27c
Compare
There was a problem hiding this comment.
Pull request overview
Enables layer discovery/matching in projmgr when a context is specified with only a board (no selected device), by relaxing for-device name filtering when the context has no device name.
Changes:
- Update
ProjMgrWorker::CheckBoardDeviceInLayerto skipfor-devicename comparison when the context has no device name, while keeping vendor/processor comparisons when available. - Update unit test expectation to allow matching when
context.deviceis empty and the layer has a device-name constraint.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 2 comments.
| File | Description |
|---|---|
| tools/projmgr/src/ProjMgrWorker.cpp | Relaxes for-device name matching to support board-only layer discovery scenarios. |
| tools/projmgr/test/src/ProjMgrWorkerUnitTests.cpp | Adjusts unit test expectations for device-name constrained layers when no device is selected. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Test Results 2 files - 37 14 suites - 107 14m 42s ⏱️ - 4m 12s Results for commit d95b434. ± Comparison against base commit aeee696. This pull request removes 451 tests.♻️ This comment has been updated with latest results. |
Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com>
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #2533 +/- ##
==========================================
- Coverage 65.36% 65.36% -0.01%
==========================================
Files 147 147
Lines 26800 26800
Branches 16237 16237
==========================================
- Hits 17518 17517 -1
Misses 7075 7075
- Partials 2207 2208 +1
Flags with carried forward coverage won't be shown. Click here to find out more.
🚀 New features to boost your workflow:
|
Fixes
Changes
for-devicename when the current context does not specify adevice. This supports layer discovery when only theboardis specified while preservingprocessorchecks when available.Checklist