Skip to content

Allow board layer matching without a selected device#2533

Merged
brondani merged 2 commits into
mainfrom
allow-board-layer-matching
Jul 24, 2026
Merged

Allow board layer matching without a selected device#2533
brondani merged 2 commits into
mainfrom
allow-board-layer-matching

Conversation

@brondani

@brondani brondani commented Jul 24, 2026

Copy link
Copy Markdown
Collaborator

Fixes

Changes

  • Skip comparing the layer's for-device name when the current context does not specify a device. This supports layer discovery when only the board is specified while preserving processor checks when available.
  • Update the unit test to expect successful matching for a board-only context with a device-name constraint.

Checklist

  • 🤖 This change is covered by unit tests (if applicable).
  • 🤹 Manual testing has been performed (if necessary).
  • 🛡️ Security impacts have been considered (if relevant).
  • 📖 Documentation updates are complete (if required).
  • 🧠 Third-party dependencies and TPIP updated (if required).

Skip comparing the layer's for-device name when the current context does
not specify a device. This supports layer discovery where only the board
is known while preserving vendor and processor checks when available.

Update the unit test to expect successful matching for a board-only
context with a device-name constraint.

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Enables layer discovery/matching in projmgr when a context is specified with only a board (no selected device), by relaxing for-device name filtering when the context has no device name.

Changes:

  • Update ProjMgrWorker::CheckBoardDeviceInLayer to skip for-device name comparison when the context has no device name, while keeping vendor/processor comparisons when available.
  • Update unit test expectation to allow matching when context.device is empty and the layer has a device-name constraint.

Reviewed changes

Copilot reviewed 2 out of 2 changed files in this pull request and generated 2 comments.

File Description
tools/projmgr/src/ProjMgrWorker.cpp Relaxes for-device name matching to support board-only layer discovery scenarios.
tools/projmgr/test/src/ProjMgrWorkerUnitTests.cpp Adjusts unit test expectations for device-name constrained layers when no device is selected.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Comment thread tools/projmgr/test/src/ProjMgrWorkerUnitTests.cpp
Comment thread tools/projmgr/src/ProjMgrWorker.cpp Outdated
@github-actions

github-actions Bot commented Jul 24, 2026

Copy link
Copy Markdown

Test Results

  2 files   -    37   14 suites   - 107   14m 42s ⏱️ - 4m 12s
475 tests  -   451  475 ✅  - 434  0 💤  - 17  0 ❌ ±0 
950 runs   - 1 041  950 ✅  - 990  0 💤  - 51  0 ❌ ±0 

Results for commit d95b434. ± Comparison against base commit aeee696.

This pull request removes 451 tests.
AuxCmdTests ‑ MkdirCmdTest
AuxCmdTests ‑ RmdirCmdTest
AuxCmdTests ‑ TouchCmdTest
BuildSystemGeneratorTests ‑ GenAuditFile
BuildSystemGeneratorTests ‑ GenAuditFile_WithOut_Existing_Audit_File
BuildSystemGeneratorTests ‑ GenAuditFile_With_Existing_Audit_File
BuildSystemGeneratorTests ‑ GetString
BuildSystemGeneratorTests ‑ StrConv
BuildSystemGeneratorTests ‑ StrNorm
CBuildGCCTests ‑ Asm
…

♻️ This comment has been updated with latest results.

Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com>
@brondani
brondani marked this pull request as ready for review July 24, 2026 08:16
@brondani
brondani requested a review from edriouk July 24, 2026 08:16
@codecov

codecov Bot commented Jul 24, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 65.36%. Comparing base (aeee696) to head (d95b434).

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #2533      +/-   ##
==========================================
- Coverage   65.36%   65.36%   -0.01%     
==========================================
  Files         147      147              
  Lines       26800    26800              
  Branches    16237    16237              
==========================================
- Hits        17518    17517       -1     
  Misses       7075     7075              
- Partials     2207     2208       +1     
Flag Coverage Δ
projmgr-cov 87.95% <100.00%> (-0.02%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files with missing lines Coverage Δ
tools/projmgr/src/ProjMgrWorker.cpp 87.42% <100.00%> (-0.03%) ⬇️
🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@brondani
brondani merged commit a7fcd69 into main Jul 24, 2026
30 checks passed
@brondani
brondani deleted the allow-board-layer-matching branch July 24, 2026 09:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants