framework: Remove dhowett's driver - #1975
Conversation
|
cc @DHowett |
Most of it (Battery Charge Control and LED control) has been upstream for a while. Only fan control and privacy switches hasn't. The module hasn't been updated in two years. Signed-off-by: Daniel Schaefer <dhs@frame.work>
|
as the @DHowett in question: yes absolutely, upstream is much more capable now than it was in 2022 when I started work on framework-laptop-kmod. It has no place in a modern distro :) |
| }; | ||
| # Make sure that the charge control driver is loaded | ||
| extraModProbeConfig = '' | ||
| options cros_charge_control probe-with_fwk_charge_control=1 |
There was a problem hiding this comment.
@t-8ch this is still needed/recommended, right?
There was a problem hiding this comment.
AFAIK the upstream interface used by this driver (and therefore the driver itself) is still completely broken on current Framework firmware versions.
And given that the command EC_CMD_CHARGE_LIMIT_CONTROL 0x3E03 is still present in the latest firmware, the module parameter is still necessary.
But this parameter is meant to be set by the end user. As they will need to make sure not to use EC_CMD_CHARGE_LIMIT_CONTROL in any way, as that will also break the driver. Setting the parameter automatically behind their backs defeats its whole purpose.
Fan control is on my todo list. Privacy switches in its current form would be trivial to do. |
3 participants
Description of changes
Most of it (Battery Charge Control and LED control) has been upstream for a while. Only fan control and privacy switches hasn't.
The module hasn't been updated in two years.
Things done
nixos-hardwareandimporting it via
<nixos-hardware>or Flake input