support multiple libraries in one package - #717
Open
m1-s wants to merge 1 commit into
Open
Conversation
m1-s
marked this pull request as ready for review
April 19, 2026 16:43
Author
|
@L0neGamer fyi |
ju1m
reviewed
Aug 1, 2026
| , _testDepends = error "undefined Derivation.testDepends" | ||
| , _benchmarkDepends = error "undefined Derivation.benchmarkDepends" | ||
| , _subLibraryDepends = mempty | ||
| , _subLibraryDependencies = mempty |
There was a problem hiding this comment.
suggestion: shouldn't those be error like others?
| -- For backwards compatibility, libraryHaskellDepends is emitted as the | ||
| -- union of the main library deps and all sub-library deps. New consumers | ||
| -- should prefer the separate subLibraryDepends attrset. | ||
| mergedLibraryDepends = _libraryDepends `mappend` foldMap id (Map.elems subLibDeps) |
There was a problem hiding this comment.
Suggested change
| mergedLibraryDepends = _libraryDepends `mappend` foldMap id (Map.elems subLibDeps) | |
| mergedLibraryDepends = _libraryDepends `mappend` fold (Map.elems subLibDeps) |
Unless you want a strict version, then it would be:
Suggested change
| mergedLibraryDepends = _libraryDepends `mappend` foldMap id (Map.elems subLibDeps) | |
| mergedLibraryDepends = _libraryDepends `mappend` foldMap' id (Map.elems subLibDeps) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR adds support for multiple libraries in one package. These libraries can have visibility public or private.
Fixes #448
(This is my first contribution in this repo. I am not familiar with the codebase. Happy to hear feedback.)