Skip to content

feat(auth): add account discovery during new-user onboarding - #6879

Merged
ErickRDev merged 1 commit into
masterfrom
erickr/NAN-6357/add-account-discovery-onboarding-flow
Aug 4, 2026
Merged

feat(auth): add account discovery during new-user onboarding#6879
ErickRDev merged 1 commit into
masterfrom
erickr/NAN-6357/add-account-discovery-onboarding-flow

Conversation

@ErickRDev

@ErickRDev ErickRDev commented Jul 22, 2026

Copy link
Copy Markdown
Contributor

Add a short-lived, server-side account-discovery marker for newly created password and managed-auth users. The discovery flow finds and caches the best same-domain account recommendation while exposing only its name to the client.

Keep marker persistence best-effort so discovery failures never block signup. No-match, rejection, and discovery-error paths fall back to the existing hear-about-us onboarding guard.

Review in cubic

@ErickRDev ErickRDev self-assigned this Jul 22, 2026
@linear-code

linear-code Bot commented Jul 22, 2026

Copy link
Copy Markdown

NAN-6357

@github-actions

github-actions Bot commented Jul 22, 2026

Copy link
Copy Markdown
Contributor

Preview Deploy

Status URL Deploy Logs Last Updated
✅ Ready Preview URL Deploy Logs 4 Aug 2026, 12:16 UTC

@cubic-dev-ai cubic-dev-ai Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All reported issues were addressed across 16 files

Reply with feedback, questions, or to request a fix.

Re-trigger cubic

@ErickRDev
ErickRDev force-pushed the erickr/NAN-6357/add-account-discovery-onboarding-flow branch from 8a633cd to 150c056 Compare July 23, 2026 15:25
@ErickRDev
ErickRDev force-pushed the erickr/NAN-6357/add-account-discovery-onboarding-flow branch from 150c056 to deec15a Compare July 23, 2026 15:33
Base automatically changed from erickr/NAN-5056/request-to-join-on-signup to master July 23, 2026 16:34
@ErickRDev
ErickRDev force-pushed the erickr/NAN-6357/add-account-discovery-onboarding-flow branch from deec15a to 92692b9 Compare July 24, 2026 14:54
@ErickRDev
ErickRDev force-pushed the erickr/NAN-6357/add-account-discovery-onboarding-flow branch from 92692b9 to 16acda9 Compare July 24, 2026 18:57
@ErickRDev
ErickRDev marked this pull request as ready for review July 24, 2026 21:04
@ErickRDev

Copy link
Copy Markdown
Contributor Author

This PR will be merged as a stack once the feature is fully implemented (still missing NAN-6358 and NAN-6359).

@ErickRDev
ErickRDev requested a review from a team July 24, 2026 21:55
@ErickRDev
ErickRDev force-pushed the erickr/NAN-6357/add-account-discovery-onboarding-flow branch from 16acda9 to bc36c5c Compare July 28, 2026 21:45
@ErickRDev
ErickRDev force-pushed the erickr/NAN-6357/add-account-discovery-onboarding-flow branch from bc36c5c to 2f96730 Compare July 31, 2026 22:37
@ErickRDev
ErickRDev force-pushed the erickr/NAN-6357/add-account-discovery-onboarding-flow branch from 2f96730 to fdf52bd Compare July 31, 2026 22:55
@ErickRDev
ErickRDev requested a review from agusayerza July 31, 2026 23:39
@ErickRDev
ErickRDev force-pushed the erickr/NAN-6357/add-account-discovery-onboarding-flow branch from fdf52bd to 9d5c123 Compare August 3, 2026 12:24
Comment thread packages/server/lib/controllers/v1/account/onboarding/accountDiscoverySession.ts Outdated
@ErickRDev
ErickRDev force-pushed the erickr/NAN-6357/add-account-discovery-onboarding-flow branch from 9d5c123 to b21d6bd Compare August 3, 2026 22:06
@ErickRDev
ErickRDev added this pull request to the merge queue Aug 4, 2026
@github-merge-queue
github-merge-queue Bot removed this pull request from the merge queue due to failed status checks Aug 4, 2026
Persist account-discovery eligibility when a password user confirms their
email, or when managed auth creates a new non-invited user.

After sign-in, users without an explicit safe return path are directed to
account discovery. MFA preserves that server-selected destination.

The first discovery request atomically consumes eligibility and caches the
same-domain account recommendation in the session, keeping the recommended
account ID server-side for follow-up actions. Users without a match continue
to the existing onboarding flow.
@ErickRDev
ErickRDev force-pushed the erickr/NAN-6357/add-account-discovery-onboarding-flow branch from b21d6bd to 649f483 Compare August 4, 2026 12:13
@ErickRDev
ErickRDev added this pull request to the merge queue Aug 4, 2026
Merged via the queue into master with commit 20b0152 Aug 4, 2026
38 checks passed
@ErickRDev
ErickRDev deleted the erickr/NAN-6357/add-account-discovery-onboarding-flow branch August 4, 2026 12:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants