test: skip system NVML tests when the symbol is absent in older bindings - #2390
test: skip system NVML tests when the symbol is absent in older bindings#2390rluo8 wants to merge 13 commits into
Conversation
|
6955804 to
7f9f7ee
Compare
mdboom
left a comment
There was a problem hiding this comment.
unsupported_before is meant to indicate that a feature isn't available on a specific hardware architecture. It's not meant to indicate that a function isn't available on a specific CTK version.
We should skip each of the failing tests individually, based on the CTK version.
For example:
@pytest.mark.skipif(get_user_mode_driver_version() < (13, 0))
|
I think we should check the KMD version not UMD version? |
7f9f7ee to
7433f3a
Compare
|
Thanks @mdboom , @leofang. I updated the patch to skip the two cases when kernel mode driver < R580. Verified on a forward compatibility system (UMD 13.0 + KMD 575), the tests would still fail with FunctionNotFoundError if using UMD check. After switching to use KMD version check, the two tests could be skipped correctly. |
Pull Request is not mergeable
|
Hi @mdboom , the CI check have all passed now. It seems that there's something wrong with Github and it disabled the auto-merge. Could you please help merge this PR? |
Description
This is to fix bug 6179497, and it's a test only issue.
Tests failed when using cuda.core v1.1.0 and cuda bindings 12.9.7.
FAILED system/test_system_device.py::test_addressing_mode
FunctionNotFoundError: function nvmlDeviceGetAddressingMode is not found
FAILED system/test_system_device.py::test_repair_status
FunctionNotFoundError: function nvmlDeviceGetRepairStatus is not found
This issue was originally fixed in pr #1898, but the fix in cuda.bindings wasn't inculded in cuda 12.9.x.
This fix back-stops the skip on the cuda.core test side (independent of the cuda.bindings version): a missing NVML symbol is skipped rather than failed.
Checklist