Skip to content

create a the log hooks for cucascade #175

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
aminaramoon wants to merge 1 commit into
base: main
Choose a base branch
from
Open

create a the log hooks for cucascade #175

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
36 changes: 36 additions & 0 deletions CMakeLists.txt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -46,6 +46,22 @@ option(
"Build the S3 parquet benchmark (requires aws-sdk-cpp; NOT a cuCascade dependency)"
OFF)

# Compile-time floor for the CUCASCADE_LOG_* macros, as the underlying value of
# a cucascade::log::level (0 = trace ... 6 = off). The default keeps every call
# site and leaves filtering to the runtime threshold; raising it strips the
# cheaper levels from the binary entirely.
#
# Propagated PUBLIC because consumers expand the same macros. That is safe even
# if a consumer overrides it: the definition is read only inside the macros, not
# inside any inline function body or type, so a mismatch prunes call sites
# differently rather than violating the ODR.
set(CUCASCADE_MIN_LOG_LEVEL
"0"
CACHE
STRING
"Compile out CUCASCADE_LOG_* call sites below this level (0=trace, 1=debug, 2=info, 3=warn, 4=error, 5=fatal, 6=off)"
)

# Swappable third-party backends for the io layer. The io code was ported from a
# codebase with its own vendored dependencies. These knobs let an embedding host
# (e.g. sirius) reuse the copies it already links instead of the
Expand Down Expand Up @@ -340,6 +356,7 @@ if(NOT CUCASCADE_TOPOLOGY_ONLY)
add_subdirectory(src/cuda)
endif()
add_subdirectory(src/memory)
add_subdirectory(src/log)
if(NOT CUCASCADE_TOPOLOGY_ONLY)
add_subdirectory(src/data)
endif()
Expand All @@ -356,13 +373,22 @@ set(CUCASCADE_PUBLIC_INCLUDE_DIRS
$<BUILD_INTERFACE:${CMAKE_CURRENT_SOURCE_DIR}/include>
$<INSTALL_INTERFACE:include>)

# Carried by every target that exposes include/cucascade/log/logging.hpp. The
# object libraries need it for cuCascade's own call sites; the installable
# static/shared targets are assembled from $<TARGET_OBJECTS:...> rather than by
# linking, so PUBLIC usage requirements do not flow across and must be repeated.
set(CUCASCADE_PUBLIC_COMPILE_DEFS
CUCASCADE_MIN_LOG_LEVEL=${CUCASCADE_MIN_LOG_LEVEL})

if(NOT CUCASCADE_TOPOLOGY_ONLY)
set(CUCASCADE_PUBLIC_LINK_LIBS rmm::rmm CUDA::cudart_static Threads::Threads
Numa::Numa)

# Set include directories for the object library
target_include_directories(cucascade_objects
PUBLIC ${CUCASCADE_PUBLIC_INCLUDE_DIRS})
target_compile_definitions(cucascade_objects
PUBLIC ${CUCASCADE_PUBLIC_COMPILE_DEFS})

# Link dependencies to object library
target_link_libraries(cucascade_objects PUBLIC ${CUCASCADE_PUBLIC_LINK_LIBS})
Expand Down Expand Up @@ -424,6 +450,8 @@ endif()

target_include_directories(cucascade_topology_discovery_objects
PUBLIC ${CUCASCADE_PUBLIC_INCLUDE_DIRS})
target_compile_definitions(cucascade_topology_discovery_objects
PUBLIC ${CUCASCADE_PUBLIC_COMPILE_DEFS})
target_link_libraries(cucascade_topology_discovery_objects
PUBLIC CUDA::nvml_static rmm::rmm)
target_compile_features(cucascade_topology_discovery_objects PUBLIC cxx_std_20)
Expand All @@ -446,6 +474,8 @@ if(CUCASCADE_BUILD_STATIC_LIBS)
PRIVATE CUDA::nvml_static rmm::rmm)
target_include_directories(cucascade_topology_discovery_static
PUBLIC ${CUCASCADE_PUBLIC_INCLUDE_DIRS})
target_compile_definitions(cucascade_topology_discovery_static
PUBLIC ${CUCASCADE_PUBLIC_COMPILE_DEFS})
target_compile_features(cucascade_topology_discovery_static PUBLIC cxx_std_20)
# Work around a bug in libnvidia-ml.so - it attempts to call back into the
# stub library (https://nvbugspro.nvidia.com/bug/6174166)
Expand All @@ -463,6 +493,8 @@ if(CUCASCADE_BUILD_STATIC_LIBS)

target_include_directories(cucascade_static
PUBLIC ${CUCASCADE_PUBLIC_INCLUDE_DIRS})
target_compile_definitions(cucascade_static
PUBLIC ${CUCASCADE_PUBLIC_COMPILE_DEFS})
target_link_libraries(
cucascade_static PUBLIC ${CUCASCADE_PUBLIC_LINK_LIBS}
cucascade_topology_discovery_static)
Expand Down Expand Up @@ -524,6 +556,8 @@ if(CUCASCADE_BUILD_SHARED_LIBS)
PRIVATE CUDA::nvml_static rmm::rmm)
target_include_directories(cucascade_topology_discovery_shared
PUBLIC ${CUCASCADE_PUBLIC_INCLUDE_DIRS})
target_compile_definitions(cucascade_topology_discovery_shared
PUBLIC ${CUCASCADE_PUBLIC_COMPILE_DEFS})
target_compile_features(cucascade_topology_discovery_shared PUBLIC cxx_std_20)
# Work around a bug in libnvidia-ml.so - it attempts to call back into the
# stub library (https://nvbugspro.nvidia.com/bug/6174166)
Expand All @@ -539,6 +573,8 @@ if(CUCASCADE_BUILD_SHARED_LIBS)

target_include_directories(cucascade_shared
PUBLIC ${CUCASCADE_PUBLIC_INCLUDE_DIRS})
target_compile_definitions(cucascade_shared
PUBLIC ${CUCASCADE_PUBLIC_COMPILE_DEFS})
target_link_libraries(
cucascade_shared PUBLIC ${CUCASCADE_PUBLIC_LINK_LIBS}
cucascade_topology_discovery_shared)
Expand Down
Loading