Refactor enum to string functions - #9752
Merged
Merged
Conversation
Contributor
|
Auto-sync is disabled for draft pull requests in this repository. Workflows must be run manually. Contributors can view more details about this message here. |
Jacobfaib
approved these changes
Jul 8, 2026
Jacobfaib
left a comment
Jacobfaib
left a comment
Contributor
There was a problem hiding this comment.
LGTM, thanks for the quick PR!
| #if __cpp_lib_format >= 201907L && !defined(_CCCL_DOXYGEN_INVOKED) | ||
| template <::cuda::std::same_as<char> CharT> | ||
| struct std::formatter<CUB_NS_QUALIFIER::BlockHistogramMemoryPreference, CharT> : formatter<const CharT*, CharT> | ||
| struct ::std::formatter<CUB_NS_QUALIFIER::BlockHistogramMemoryPreference, CharT> : formatter<const CharT*, CharT> |
Contributor
There was a problem hiding this comment.
formatter as well? Or is that in the cub namespace?
davebayer
requested changes
Jul 8, 2026
davebayer
left a comment
davebayer
left a comment
Contributor
There was a problem hiding this comment.
We can't fully qualify the formatter specializations, because there is a bug in gcc that makes it refuse to compile the code :D
davebayer
reviewed
Jul 8, 2026
Contributor
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Path: .coderabbit.yaml Review profile: CHILL Plan: Enterprise Run ID: 📒 Files selected for processing (10)
🚧 Files skipped from review as they are similar to previous changes (10)
📝 WalkthroughSummary by CodeRabbit
WalkthroughChangesCUB enum-to-string helpers add CUB stringification helpers
Possibly related PRs
Suggested reviewers: Comment |
bernhardmgruber
force-pushed
the
ref_to_string
branch
from
July 13, 2026 14:19
704b941 to
32515f8
Compare
bernhardmgruber
force-pushed
the
ref_to_string
branch
from
July 13, 2026 14:21
482c397 to
da8bd12
Compare
davebayer
approved these changes
Jul 13, 2026
bernhardmgruber
enabled auto-merge (squash)
July 13, 2026 14:28
This comment has been minimized.
This comment has been minimized.
Contributor
🥳 CI Workflow Results🟩 Finished in 2h 38m: Pass: 100%/287 | Total: 6d 15h | Max: 2h 38m | Hits: 48%/403232See results here. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
As suggested by @Jacobfaib on #9745, this PR:
to_stringfunctions out ofswitchesFully qualifiesstd::formatterspecializations_CCCL_API