feat(assets-controller)!: fetch multicall address from config registry - #9717
Open
mikesposito wants to merge 2 commits into
Open
feat(assets-controller)!: fetch multicall address from config registry#9717mikesposito wants to merge 2 commits into
mikesposito wants to merge 2 commits into
Conversation
mikesposito
marked this pull request as ready for review
July 30, 2026 17:18
mikesposito
temporarily deployed
to
default-branch
July 30, 2026 17:18 — with 
GitHub Actions
Inactive
GitHub Actions
Inactive
![cursor[bot]](https://avatars.githubusercontent.com/in/1210556?s=60&v=4){kind=small}
There was a problem hiding this comment.
Cursor Bugbot has reviewed your changes and found 1 potential issue.
❌ Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, have a team admin enable autofix in the Cursor dashboard.
Reviewed by Cursor Bugbot for commit 790f363. Configure here.
mikesposito
commented
Jul 30, 2026
| rpcProviders: RpcProvidersSchema, | ||
| blockExplorerUrls: BlockExplorerUrlsSchema, | ||
| config: ChainConfigSchema, | ||
| contracts: optional(NetworkContractsSchema), |
Member
Author
There was a problem hiding this comment.
Added to the registry in https://github.com/MetaMask/mm-config-registry/pull/30
mikesposito
force-pushed
the
me/assets-controller-drv2
branch
from
July 30, 2026 17:55
0c4fe55 to
1de5137
Compare
mikesposito
force-pushed
the
me/assets-controller-drv2
branch
from
July 30, 2026 17:58
1de5137 to
2b93102
Compare
Member
Author
|
@metamaskbot publish-preview |
Contributor
|
Preview builds have been published. Learn how to use preview builds in other projects. Expand for full list of packages and versions. |
This was referenced Jul 30, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Explanation
MulticallClientfromassets-controlleris being wired toconfig-registry-controllervia messenger call. The registry is used as primary source for multicall3 addresses, and the existing bundle constant is used only as fallback.References
Checklist
Note
Medium Risk
Breaking messenger and export changes affect all AssetsController consumers; wrong multicall addresses could break EVM token balance RPC batching, though hardcoded fallbacks limit blast radius on known chains.
Overview
EVM balance batching now resolves Multicall3 contract addresses from the config registry first, with existing per-chain constants as fallback.
RpcDataSourceconstructsMulticallClientwith agetMulticall3AddressForChaincallback that callsConfigRegistryController:getNetworkConfigByCaip2ChainId(CAIP-2eip155:{chainId}) and readscontracts.multicall3.AssetsControllerMessengermust delegate that action—a breaking change for hosts wiring the controller.On the registry side, network configs gain an optional
contractsobject (validated API schema;multicall3as strict hex).ConfigRegistryControllerMethodActionsis removed from exports in favor of the specific action types (also breaking for type consumers).MulticallClient’s constructor now takes a single options object (getProvider,getMulticall3AddressForChain, optional batch config); tests and mocks were updated accordingly, and@metamask/config-registry-controlleris added as a dependency of@metamask/assets-controller.Reviewed by Cursor Bugbot for commit 2b93102. Bugbot is set up for automated code reviews on this repo. Configure here.