feat: refetch defi positions if they are still loading - #9711
Open
bergarces wants to merge 7 commits into
Open
Conversation
![cursor[bot]](https://avatars.githubusercontent.com/in/1210556?s=60&v=4){kind=small}
Contributor
Author
|
@metamaskbot publish-preview |
Contributor
Author
|
@metamaskbot publish-preview |
There was a problem hiding this comment.
Cursor Bugbot has reviewed your changes and found 1 potential issue.
❌ Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, have a team admin enable autofix in the Cursor dashboard.
Reviewed by Cursor Bugbot for commit d77c814. Configure here.
Contributor
|
Preview builds have been published. Learn how to use preview builds in other projects. Expand for full list of packages and versions. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Explanation
References
Checklist
Note
Medium Risk
Changes fetch lifecycle and timing (longer-running promises, background polls on account/currency switches) for DeFi portfolio state; behavior is well covered by new tests but affects wallet balance/DeFi UX paths.
Overview
DeFiPositionsControllerV2.fetchDeFiPositionsno longer stops when the Accounts API returnsprocessingDefiPositions: true. It polls (5s interval, up to 5 attempts), invalidates the v6 balances TanStack cache between retries, and usesstaleTime: 0on follow-up attempts so polls are not stuck on a cached “still processing” snapshot.forceRefreshonly bypasses cache on the first attempt.Ready accounts are merged into state immediately on each response; still-indexing accounts keep prior positions until they become ready or the attempt cap is hit. The method resolves only after the fetch and any polls finish.
Concurrency: one in-flight promise per sorted selected-account IDs +
vsCurrency. Same selection/currency joins the existing poll; a different account group or fiat currency starts a separate fetch while earlier polls keep running (switching back can rejoin an earlier in-flight poll for that key).Reviewed by Cursor Bugbot for commit d77c814. Bugbot is set up for automated code reviews on this repo. Configure here.