temp(assets-controller): sentry subspan tracing decorators. - #9689
Draft
Prithpal-Sooriya wants to merge 1 commit into
Draft
temp(assets-controller): sentry subspan tracing decorators.#9689Prithpal-Sooriya wants to merge 1 commit into
Prithpal-Sooriya wants to merge 1 commit into
Conversation
…pdate pipelines - Nested Sentry spans for asset fetching under a single root span per pipeline, reducing transaction count. - Updated `AssetsFullFetch`, `AssetsControllerFirstInitFetch`, and related spans to be subspans of `AssetsFetchPipeline` and `AssetsBackgroundFetch`. - Adjusted `AssetsFullFetch.duration_ms` to measure middleware execution only. - Implemented best-effort tracing for rejected promises in asset updates, ensuring underlying work still executes. - Added tests to verify new tracing behavior and ensure correct span nesting. This change improves performance monitoring and error handling in asset management workflows.
Prithpal-Sooriya
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Explanation
AssetsFullFetch,AssetsControllerFirstInitFetch, and related spans to be subspans ofAssetsFetchPipelineandAssetsBackgroundFetch.AssetsFullFetch.duration_msto measure middleware execution only.This change improves performance monitoring and error handling in asset management workflows.
References
Checklist