feat(ramps-controller): export terminal order status helpers (TRAM-3703) - #9679
Open
wenfix wants to merge 4 commits into
Open
feat(ramps-controller): export terminal order status helpers (TRAM-3703)#9679wenfix wants to merge 4 commits into
wenfix wants to merge 4 commits into
Conversation
Share TERMINAL_ORDER_STATUSES and isTerminalOrderStatus() so mobile and other consumers stop duplicating the terminal status set (TRAM-3703). Co-authored-by: Cursor <cursoragent@cursor.com>
…r-status Resolve changelog and RampsController import conflicts after syncing with latest main. Co-authored-by: Cursor <cursoragent@cursor.com>
Merge resolution left two [Unreleased] sections, which failed changelog validation in CI. Co-authored-by: Cursor <cursoragent@cursor.com>
Required by the changelog check workflow for user-facing changes. Co-authored-by: Cursor <cursoragent@cursor.com>
Contributor
Author
|
@metamaskbot publish-previews |
Contributor
|
Preview builds have been published. Learn how to use preview builds in other projects. Expand for full list of packages and versions. |
10 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Explanation
Mobile and other ramps consumers each maintained their own copy of the terminal order status set (
Completed,Failed,Cancelled,IdExpired) for UI navigation, analytics, and polling guards. Those copies had already drifted — for example,BankDetailswas missingIdExpired.This PR adds a shared
orderStatus.tsmodule (following the same pattern asquoteClassification.tsandproviderAvailability.ts) and exports:TERMINAL_ORDER_STATUSES— the canonicalReadonlySet<RampsOrderStatus>isTerminalOrderStatus(status)— predicate wrapperRampsControllernow imports these constants instead of defining private duplicates, so the controller and consumers stay in sync.References
Checklist
Made with Cursor