feat: Integrate SubscriptionController into wallet initialization - #9598
Open
tuna1207 wants to merge 15 commits into
Open
feat: Integrate SubscriptionController into wallet initialization#9598tuna1207 wants to merge 15 commits into
tuna1207 wants to merge 15 commits into
Conversation
pedronfigueiredo
previously approved these changes
Jul 23, 2026
…r better readability
…er import in SubscriptionController.test.ts
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Explanation
Adds SubscriptionController as a default initialized unit in @metamask/wallet, with injectable or default SubscriptionService construction and AuthenticationController messenger delegation.
@metamask/wallet is the shared controller-integration layer for extension, mobile, and other clients. Build-specific and runtime values are injected via instanceOptions rather than hardcoded.
Breaking changes
References
Checklist
Note
Medium Risk
Breaking wallet
instanceOptionsand subscription billing/auth integration require all hosts to supply config and register AuthenticationController; misconfiguration could break subscription API calls but does not directly alter keyring or transaction signing.Overview
SubscriptionController can now be constructed with either an injected
subscriptionServiceor service config (env,fetchFunction, optionalgetAccessToken/captureException); the default path buildsSubscriptionServiceand usesAuthenticationController:getBearerTokenwhen no token getter is supplied. The messenger no longer declares unusedAuthenticationController:stateChange(AllowedEventsexport removed).@metamask/wallet adds SubscriptionController to default initialization: a required
instanceOptions.subscriptionControllerslot, a new init module that delegates auth actions to the root messenger, dependency on@metamask/subscription-controller, and tests/docs/CODEOWNERS updates. wallet-cli passes{ fetchFunction: globalThis.fetch }so the daemon gets production API defaults without extra env wiring.Changelogs document breaking wallet and subscription-controller API changes; eslint suppressions for removed
index.tsexports are cleaned up.Reviewed by Cursor Bugbot for commit caa3113. Bugbot is set up for automated code reviews on this repo. Configure here.