feat: reuse paging-derived accounts to avoid redundant device I/O at unlock - #613
Draft
gantunesr wants to merge 5 commits into
Draft
feat: reuse paging-derived accounts to avoid redundant device I/O at unlock#613gantunesr wants to merge 5 commits into
gantunesr wants to merge 5 commits into
Conversation
Member
Author
|
@metamaskbot publish-preview |
|
Preview builds have been published. See these instructions (from the Expand for full list of packages and versions. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary of the changes:
#pagingCache: Map<string, { hdPath, address, publicKey, chainCode? }>keyed by derivation path.#getAccountsBIP44now callsbridge.getPublicKeydirectly instead ofthis.unlock(path), so it can capture the full payload and stash{ hdPath, address, publicKey: payload.publicKey, chainCode: payload.chainCode }into the cache. Error handling and thehdkupdate are preserved.addAccountschecks#pagingCache.get(path)first; on a hit it reusescached.addressand skipsunlock(path)→bridge.getPublicKey. On a miss it falls back toawait this.unlock(path). Note: The non-Ledger Live branch is unchanged.forgetDevice,setHdPath(when the path actually changes),destroy, and defensively at the start ofaddAccountswhen the device is disconnected (!this.isConnected()).invalidatePagingCache()method for external disconnect handlers, backed by private#invalidatePagingCache().Examples
N/A