Repair external node links and deeplink the live coverage overlay - #554
Merged
Conversation
- remove Armooo's MeshView from sidebar tools, elsewhere defaults, and
sample config (instance is offline)
- point Bay Mesh Explorer at the new meshview.bayme.sh instance, which
deeplinks by decimal node id (/node/{node_id_int})
- fix NaN in map panel elsewhere links: node ids arriving with a "!"
prefix broke parseInt; use convertNodeIdFromHexToInt and strip the
prefix from {node_id_hex} substitutions too
- update config.toml.sample examples to match
Toggling the coverage pill now mirrors into the map URL (cov=1|0) so a shared link reproduces the sharer's overlay state. The param overrides the viewer's saved preference for the session without overwriting it, pristine URLs are never stamped with cov=0, and true/false spellings are accepted on read. Written via history.replaceState like the lat/lng/z sync so toggling never re-renders the map route.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
fix(ui): repair dead and stale external node links
All four default "Elsewhere" links on the node panel were broken in some way:
config.toml.sample) — the instance is offline.meshview.bayme.sh,which deeplinks by decimal node id:
https://meshview.bayme.sh/node/{node_id_int}.?node_id=NaNon the map panel: node ids arriving with a!prefix brokeparseInt(id, 16). The panel now usesconvertNodeIdFromHexToInt, andresolveElsewhereUrlalso strips!from{node_id_hex}substitutions forcustom-configured templates.
Note for operators: instances that set
mesh.tools/mesh.elsewhere_linksintheir own
config.tomloverride these defaults and need the same URL updates(the Discord bot's "View Elsewhere" field reads the same config section).
feat(map): deeplink the live coverage overlay via
?cov=Toggling the coverage pill now mirrors into the map URL (
cov=1|0) so a sharedlink reproduces the sharer's overlay state alongside the existing
lat/lng/z:overwriting it (same principle as the LOS share links).
cov=0— the param only appears oncethe overlay has been on; an explicit
cov=0is kept so links shared bysomeone with the overlay off still override a viewer whose default is on.
cov=true/falseaccepted on read, normalized to1/0on write.history.replaceStatelike the pan/zoom sync — toggling neverre-renders the map route. Composes with
?node=and?tool=links.Parse/write rules are pure helpers in
coverageUrlParam.tswith unit tests.Testing
?cov=param semantics)tscandeslintclean?cov=param round-trips through share links, and it survives pan/zoom URL rewrites