Skip to content

MDEV-17746: perfschema.dml_threads failed in buildbot with wrong errno #5395

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
gkodinov wants to merge 1 commit into
base: 10.11
Choose a base branch
from
+2 −2
Open

MDEV-17746: perfschema.dml_threads failed in buildbot with wrong errno #5395

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion mysql-test/suite/perfschema/r/dml_threads.result
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -9,7 +9,7 @@ update performance_schema.threads
set thread_id=12;
ERROR HY000: Invalid performance_schema usage
update performance_schema.threads
set thread_id=12 where PROCESSLIST_ID=connection_id();
set thread_id=100000 where PROCESSLIST_ID=connection_id();
ERROR HY000: Invalid performance_schema usage
update performance_schema.threads
set instrumented= 'NO' where PROCESSLIST_ID=connection_id();
Expand Down
2 changes: 1 addition & 1 deletion mysql-test/suite/perfschema/t/dml_threads.test
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -21,7 +21,7 @@ update performance_schema.threads

--error ER_WRONG_PERFSCHEMA_USAGE
update performance_schema.threads
set thread_id=12 where PROCESSLIST_ID=connection_id();
set thread_id=100000 where PROCESSLIST_ID=connection_id();

@svoj svoj Jul 17, 2026 •
edited
Loading

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

100000 might be too close to what we could reasonably get using mtr. I'd use some other value:

  • 0 - IIUC PFS still may allocate this value to some thread at early startup
  • BIGINT_MAX - almost impossible to hit in current implementation
  • connection_id() - N - can be affected by lingering connections
  • connection_id() + N - sounds reliable assuming the default connection is the most recent one.

UPD: argh, connection_id() is from a different namespace, but you got the idea.


update performance_schema.threads
set instrumented= 'NO' where PROCESSLIST_ID=connection_id();
Expand Down