Skip to content

Feature/wind module#4209

Closed
seanps wants to merge 6 commits into
MagicMirrorOrg:masterfrom
seanps:feature/wind-module
Closed

Feature/wind module#4209
seanps wants to merge 6 commits into
MagicMirrorOrg:masterfrom
seanps:feature/wind-module

Conversation

@seanps

@seanps seanps commented Jul 18, 2026

Copy link
Copy Markdown

Hello and thank you for wanting to contribute to the MagicMirror² project!

Please make sure that you have followed these 3 rules before submitting your Pull Request:

  1. Base your pull requests against the develop branch.
  2. Include these infos in the description:
  • Does the pull request solve a related issue?
  • If so, can you reference the issue like this Fixes #<issue_number>?
  • What does the pull request accomplish? Use a list if needed.
  • If it includes major visual changes please add screenshots.
  1. Please run node --run lint:fix before submitting so that
    style issues are fixed.

Note: Sometimes the development moves very fast. It is highly
recommended that you update your branch of develop before creating a
pull request to send us your changes. This makes everyone's lives
easier (including yours) and helps us out on the development team.

Thanks again and have a nice day!

SPS and others added 6 commits July 16, 2026 23:01
Auto-detects display driver (wlopm, wlr-randr, x11, vcgencmd) based on
environment. Schedule is configured via cron expressions in config.js.
Other modules can send/receive DISPLAY_POWER notifications to control
the display at runtime (e.g. from a future PIR sensor module).

Also adds CLAUDE.md with project guidance for Claude Code.

Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
Documents plan mode → feature branch → PR process to keep master
deployable to the Pi at all times.

Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
DEVLOG.md records architectural decisions and rationale.
.claude/skills/devlog/SKILL.md defines the /devlog skill schema.
First entry documents the displaypower driver auto-detection decision.

Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
Polls the Halifax Transit GTFS-RT TripUpdates feed every 30s, filters
by stop and route, and displays upcoming arrivals sorted soonest-first.
Adds gtfs-realtime-bindings as a production dependency for protobuf decoding.

Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
Add Halifax Transit real-time arrivals module
Shows GEM model wind, SmartAtlantic buoy (with staleness indicator),
and EC marine forecast with optional AI-powered plain-language rewrite
via Groq. Includes ASCII condition faces and warning banner.

Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
@rejas

rejas commented Jul 18, 2026

Copy link
Copy Markdown
Collaborator

thanks for your time to open this PR but
a) this doesnt state anything besides the title what the PR wants to achieve
b) it is not based against develop branch, although this is point 1 of our template
please elaborate and fix

@seanps

seanps commented Jul 19, 2026

Copy link
Copy Markdown
Author

Opened against wrong repo by mistake — this is for a personal fork. Apologies!

@seanps seanps closed this Jul 19, 2026
@KristjanESPERANTO

Copy link
Copy Markdown
Collaborator

@seanps Giving each of your modules its own repository, just like any other third-party module, would be the better move in the long run. Otherwise, you'll run into merge conflicts with every MagicMirror update.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants