Sanitize metric and resource names in error responses - #1232
Merged
sophieliu15 merged 1 commit intoJul 27, 2026
Conversation
laoj2
reviewed
Jul 23, 2026
Escape metricName and resourceName using %q format specifiers in error messages within pkg/adapter/translator/errors.go to prevent Reflected Cross-Site Scripting (XSS). Add unit tests in errors_test.go verifying that metric and resource names containing script/HTML tags are safely quoted in status error messages.
sophieliu15
force-pushed
the
fix-b-511329898
branch
from
July 23, 2026 18:57
71577e4 to
3501c24
Compare
laoj2
approved these changes
Jul 27, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Escape metricName and resourceName using %q format specifiers in error messages within pkg/adapter/translator/errors.go to prevent Reflected Cross-Site Scripting (XSS). Add unit tests in errors_test.go verifying that metric and resource names containing script/HTML tags are safely quoted in status error messages.