6175: add has_download filter for datasets without distribution links - #13
Closed
Aguiardavidm wants to merge 2 commits into
Closed
6175: add has_download filter for datasets without distribution links#13Aguiardavidm wants to merge 2 commits into
Aguiardavidm wants to merge 2 commits into
Conversation
This was referenced Aug 5, 2026
Merged
Author
|
Closing in favor of the ported PRs, now that this repo is deprecated: |
Merged
3 tasks
Aguiardavidm
added a commit
to GSA/datagov-harvester
that referenced
this pull request
Aug 7, 2026
Ports GSA/datagov_data_access#13 into harvester's vendored search/ package now that datagov_data_access is deprecated. Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com>
Aguiardavidm
added a commit
to GSA/datagov-catalog
that referenced
this pull request
Aug 7, 2026
Ports GSA/datagov_data_access#13 into catalog's vendored app/search/ package now that datagov_data_access is deprecated. Also documents has_download on the Dataset API response schema. Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
has_downloadboolean field to the OpenSearch dataset document/mapping, computed fromdcat.distribution[].downloadURL(DCAT-US 1.1/3.0 compatible;accessURL-only distributions do not count, per DCAT-US 3.0 semantics whereaccessURLis explicitly indirect access)has_downloadsearch filter (single checkbox, off by default) rendered via the existing genericcheckbox_groupsidebar rendererAddresses GSA/data.gov#6175.
Test plan
poetry run pytest tests/unit/search/test_search_filter_registry.py tests/unit/search/test_mappings.py tests/integration/search/test_documents.py(74 passed)poetry run ruff check/poetry run ruff format --checkon changed filesdatagov-data-accesspin in datagov-catalog and manually verify the sidebar checkbox in the browser🤖 Generated with Claude Code