Reject non-vector SE2 UKF measurements#4639
Merged
FlorianPfaff merged 2 commits intoJul 24, 2026
Merged
Conversation
Contributor
✅MegaLinter analysis: Success
Notices📣 MegaLinter 9.5.0 is out! Discover the new features and security recommendations in the release announcement. (Skip this info by defining See detailed reports in MegaLinter artifacts Your project could benefit from a custom flavor, which would allow you to run only the linters you need, and thus improve runtime performances. (Skip this info by defining
|
FlorianPfaff
marked this pull request as ready for review
July 23, 2026 16:21
FlorianPfaff
enabled auto-merge (squash)
July 23, 2026 16:21
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

Bug
SE2UKF._validate_se2_measurement()flattened the supplied measurement before validating its shape. Consequently, row vectors, column vectors, and matrices with four total elements—such as shapes(1, 4),(4, 1), and(2, 2)—were silently accepted as dual-quaternion measurements.This violates the documented
(4,)input contract and can hide upstream batching, orientation, or reshaping mistakes.Fix
(4,);Regression coverage
A focused public-API test verifies that
update_identity()rejects measurements with shapes:(1, 4);(4, 1);(2, 2).Validation
.ravel()behavior;main, and those intervening commits concern UKF-M and Bingham-filter validation rather thanSE2UKF;