fix: reject citation and blob relation keys - #227
Merged
Conversation
Make WriteCitation and WriteBlob fail closed when callers pass relation keys such as cites, derives_from, supersedes, or invalidates. The schema now rejects those keys, and the planner returns a clear validation error before it can silently drop them. Extend effort-graph, CLI, and live GraphQL coverage for CreateEffort cite rejection, cross-Effort Citation and Blob links, same-Effort Finding cites, and relations reads where the source record is outside the Effort. Update the mirrored effort-modeling skill text and the stale Finding so they describe the current Citation, Blob, and CreateEffort behavior. Change-Id: Ib7b22b93b665e011187c59b09f40066a3f2f086d Co-authored-by: Tony <tonyketcham@users.noreply.github.com>
tonyketcham
marked this pull request as ready for review
July 27, 2026 22:21
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary of changes
Closes the remaining review findings from #226 now that that PR is merged.
WriteCitationandWriteBlobfail closed when callers pass relation keys such ascites,derives_from,supersedes, orinvalidates(.strict()schemas + planner validation errors instead of silent drops).Please don't delete this checklist! Before submitting the PR, please make sure you do the following:
Does this introduce any non-backwards compatible changes?
Does this include any user config changes?