Skip to content

fix: reject citation and blob relation keys - #227

Merged
tonyketcham merged 1 commit into
mainfrom
toeknee/code-review-dependency-logic-264f
Jul 27, 2026
Merged

fix: reject citation and blob relation keys#227
tonyketcham merged 1 commit into
mainfrom
toeknee/code-review-dependency-logic-264f

Conversation

@cursor

@cursor cursor Bot commented Jul 26, 2026

Copy link
Copy Markdown

Summary of changes

Closes the remaining review findings from #226 now that that PR is merged.

  • Make WriteCitation and WriteBlob fail closed when callers pass relation keys such as cites, derives_from, supersedes, or invalidates (.strict() schemas + planner validation errors instead of silent drops).
  • Extend effort-graph, CLI, and live GraphQL coverage for CreateEffort cite rejection, cross-Effort Citation/Blob links, same-Effort Finding cites, and relations reads where the source record is outside the Effort.
  • Update the mirrored effort-modeling skill text and the stale Finding so they describe the current Citation, Blob, and CreateEffort behavior.

Please don't delete this checklist! Before submitting the PR, please make sure you do the following:

  • I added doc comments to any new public exports, and inline comments to any hard-to-understand areas
  • My changes generate no new console errors locally
  • If applicable, try to include a test that fails without this PR but passes with it

Does this introduce any non-backwards compatible changes?

  • Yes
    • Callers that previously passed forbidden relation keys on Citation/Blob writes and relied on silent stripping will now get validation errors.
  • No

Does this include any user config changes?

  • Yes
    • If so, I have updated the relevant areas of documentation
  • No
Open in Web View Automation 

Make WriteCitation and WriteBlob fail closed when callers pass relation keys such as cites, derives_from, supersedes, or invalidates. The schema now rejects those keys, and the planner returns a clear validation error before it can silently drop them.

Extend effort-graph, CLI, and live GraphQL coverage for CreateEffort cite rejection, cross-Effort Citation and Blob links, same-Effort Finding cites, and relations reads where the source record is outside the Effort.

Update the mirrored effort-modeling skill text and the stale Finding so they describe the current Citation, Blob, and CreateEffort behavior.

Change-Id: Ib7b22b93b665e011187c59b09f40066a3f2f086d

Co-authored-by: Tony <tonyketcham@users.noreply.github.com>
@tonyketcham
tonyketcham marked this pull request as ready for review July 27, 2026 22:21
@tonyketcham
tonyketcham merged commit 68b80fc into main Jul 27, 2026
19 checks passed
@tonyketcham
tonyketcham deleted the toeknee/code-review-dependency-logic-264f branch July 27, 2026 22:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants