feat: live-markdown working in both Bundle Mode and Legacy Eval Mode#769
Open
tjzel wants to merge 3 commits into
Open
feat: live-markdown working in both Bundle Mode and Legacy Eval Mode#769tjzel wants to merge 3 commits into
tjzel wants to merge 3 commits into
Conversation
war-in
reviewed
Jul 21, 2026
war-in
left a comment
war-in
left a comment
Collaborator
There was a problem hiding this comment.
Thank you for the contribution! I left two small comments and once addressed we can merge it
| ### Worklets Bundle Mode | ||
|
|
||
| If you're using [Worklets Bundle Mode](https://docs.swmansion.com/react-native-worklets/docs/bundleMode) you will have to | ||
| configure your [import forwarding](https://docs.swmansion.com/react-native-worklets/docs/worklets-babel-plugin/plugin-options#importforwarding) as follows in your `babel.config.js` file: |
Collaborator
There was a problem hiding this comment.
Let's also redirect users to the correct section of the Worklets docs about their metro setup (metro.config.js, and the patches). The current note suggests that they only have to configure import forwarding
Comment on lines
-9
to
+10
| "start": "react-native start --client-logs" | ||
| "start": "react-native start --client-logs", | ||
| "bundle-mode-start": "BUNDLE_MODE=1 react-native start --reset-cache --client-logs" |
Collaborator
There was a problem hiding this comment.
I wonder if we shouldn't make it the default 🤔 Are there any drawbacks to always enabling bundle mode?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Details
I made changes necessary for the library to be working in both modes.
Related Issues
n/a
Manual Tests
I ran the app in both modes and it works - there's also a mode display text in the example.
Linked PRs
n/a