Skip processing for SXT stacks where all angles are zero - #843
Merged
Conversation
Codecov Report❌ Patch coverage is Additional details and impacted files@@ Coverage Diff @@
## main #843 +/- ##
==========================================
+ Coverage 53.47% 55.01% +1.53%
==========================================
Files 103 103
Lines 11071 11465 +394
Branches 1476 1566 +90
==========================================
+ Hits 5920 6307 +387
+ Misses 4831 4827 -4
- Partials 320 331 +11 🚀 New features to boost your workflow:
|
stephen-riggs
changed the title
tieneupin
reviewed
Jul 21, 2026
tieneupin
approved these changes
Jul 21, 2026
tieneupin
left a comment
tieneupin
left a comment
Contributor
There was a problem hiding this comment.
The new class function's name is in the past tense, but beyond that, everything looks good!
d-j-hatton
pushed a commit
that referenced
this pull request
Aug 6, 2026
It doesn't make sense to treat stacks as tomograms if there are no tilts! TBC exactly what these are, but they appear to be focus scans on the SXT instrument. AreTomo is able to process them, but Imod is not. Instead just do the txrm to tiff conversion for any stacks which contain only zero-degree tilts. There is very little new code here, but a few bits have moved around to reuse the tiff path creation and get the right posts
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
It doesn't make sense to treat stacks as tomograms if there are no tilts!
TBC exactly what these are, but they appear to be focus scans on the SXT instrument. AreTomo is able to process them, but Imod is not.
Instead just do the txrm to tiff conversion for any stacks which contain only zero-degree tilts.
There is very little new code here, but a few bits have moved around to reuse the tiff path creation and get the right posts.