-
Notifications
You must be signed in to change notification settings - Fork 0
fixing #292
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: feature/member-site
Are you sure you want to change the base?
fixing #292
Changes from all commits
fa48abf
d002b17
071266f
0834d93
681720a
e66ac1d
ef83d55
0a3e413
e16da35
1e412bd
f9f822d
025df20
b79c817
21438fb
2423567
fe82e55
0836df2
c1412a0
c6a5b3f
42fe67f
5a0846b
8bcf0dc
f28afa3
b9b5fd2
5cbe290
89db49c
e31dced
0c7adbf
63bb8e5
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,11 +1,11 @@ | ||
| feature: | ||
| - head-branch: ['^feature/', '^feat/', '^enhancement/'] | ||
| - head-branch: ["^feature/", "^feat/", "^enhancement/"] | ||
| bug: | ||
| - head-branch: ['^bug/', '^fix/', '^hotfix/'] | ||
| - head-branch: ["^bug/", "^fix/", "^hotfix/"] | ||
| chore: | ||
| - head-branch: ['^chore/', '^task/'] | ||
| - head-branch: ["^chore/", "^task/"] | ||
| documentation: | ||
| - head-branch: ['^doc/', '^docs/'] | ||
| - head-branch: ["^doc/", "^docs/"] | ||
| dependencies: | ||
| - changed-files: | ||
| - any-glob-to-any-file: ['package.json', 'package-lock.json', 'bun.lockb'] | ||
| - any-glob-to-any-file: ["package.json", "package-lock.json", "bun.lockb"] |
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,42 @@ | ||
| name: Deploy Hacklytics to Firebase Hosting | ||
|
|
||
| on: | ||
| push: | ||
| branches: | ||
| - main | ||
| pull_request: | ||
|
|
||
| permissions: | ||
| contents: read | ||
| pull-requests: write | ||
| checks: write | ||
|
|
||
| jobs: | ||
| build_and_deploy: | ||
| runs-on: ubuntu-latest | ||
|
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Missing fork guard on deployMedium Severity The Reviewed by Cursor Bugbot for commit 0c7adbf. Configure here. |
||
|
|
||
| steps: | ||
| - uses: actions/checkout@v6 | ||
|
|
||
| - uses: pnpm/action-setup@v5 | ||
|
|
||
| - uses: actions/setup-node@v6 | ||
| with: | ||
| node-version: "22.23.1" | ||
| cache: "pnpm" | ||
|
|
||
| - name: Install dependencies | ||
| run: pnpm install | ||
|
|
||
| - name: Build Hacklytics 2027 | ||
| run: pnpm turbo run build --filter=hacklytics2027 | ||
|
|
||
| - name: Deploy to Firebase Hosting | ||
| uses: FirebaseExtended/action-hosting-deploy@v0 | ||
| with: | ||
| repoToken: ${{ secrets.GITHUB_TOKEN }} | ||
| firebaseServiceAccount: ${{ secrets.FIREBASE_SERVICE_ACCOUNT_DSGT_WEBSITE }} | ||
| projectId: dsgt-website | ||
| channelId: ${{ github.event_name == 'pull_request' && format('pr-{0}', github.event.pull_request.number) || 'live' }} | ||
| target: hacklytics | ||
| entryPoint: "." | ||


There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Duplicate Firebase deploy workflows
Medium Severity
Adding
deploy-hacklytics.ymlcreates duplicate Firebase Hosting deployments for thehacklyticstarget. Existing workflows still run, causingmainpushes to trigger two live deploys and PRs to trigger two preview deploys, which doubles CI work, checks, and PR comments.Reviewed by Cursor Bugbot for commit 0c7adbf. Configure here.