feat: remove DownloadInputData local file check - #8728
Merged
aldbr merged 2 commits intoAug 3, 2026
Conversation
chaen
previously approved these changes
Jul 31, 2026
chaen
left a comment
chaen
left a comment
Contributor
There was a problem hiding this comment.
I don't see hw the file could not be there after a successful download 🤷♂️
Contributor
|
Please review the failing unit test. |
Member
Author
|
I think the failing tests can be removed, since they are testing if |
aldbr
force-pushed
the
rm-DownloadInputData-local-file-check
branch
from
August 3, 2026 14:56
ff14f30 to
1d5b453
Compare
aldbr
approved these changes
Aug 3, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
CTAO would need the local file check in DowloadInputData to be removed in order to use some "virtual" LFNs.
BEGINRELEASENOTES
*WorkloadManagementSystem
CHANGE: remove DownloadInputData local file check
ENDRELEASENOTES