feat: highlight new pairings, dashboard sorted by filename - #1377
feat: highlight new pairings, dashboard sorted by filename#1377giannatan wants to merge 1 commit into
Conversation
…ard is sorted in alphabetical order
|
Important Review skippedAuto reviews are disabled on this repository. Please check the settings in the CodeRabbit UI or the ⚙️ Run configurationConfiguration used: Organization UI Review profile: CHILL Plan: Pro Plus Run ID: You can disable this status message by setting the Use the checkbox below for a quick retry:
✨ Finishing Touches🧪 Generate unit tests (beta)
Comment |
zih-syuan
left a comment
zih-syuan
left a comment
There was a problem hiding this comment.
Please rebase this branch onto the latest develop. Thank you!!
| if (successfulFiles.length > 0) { | ||
| const infoBadge = document.getElementById('info-badge'); | ||
| infoBadge.textContent = `Uploaded files: ${successfulFiles.join( | ||
| infoBadge.textContent = `Uplaoded files: ${successfulFiles.join( |
There was a problem hiding this comment.
Is this a typo? Should be Uploaded files
| .map((result) => result.value); | ||
|
|
||
| setTimeout(async () => { | ||
| if (successfulFiles.length > 0) { |
There was a problem hiding this comment.
If batch A succeeds and the next batch has no successful uploads, this guard skips markNewlyUploaded(), so batch A remains highlighted. Could we call it unconditionally so an empty result clears the previous highlight?
| container.classList.add('document-entry'); | ||
| container.setAttribute('draggable', 'true'); // make file or folder draggable | ||
|
|
||
| if (newlyUploadedNames.has(entry.name)) { |
There was a problem hiding this comment.
Different folders can contain entries with the same filename. Since this set persists across folder navigation and createTile() checks only entry.name, an entry in another folder could be highlighted incorrectly. Could this be scoped to the upload folder or track entry IDs?
| /cypress/downloads | ||
|
|
||
| .idea | ||
| .nvmrc |
There was a problem hiding this comment.
Is ignoring .nvmrc related to this feature? If it is only a local file, could this unrelated change be removed from the PR?
2 participants
ref: issue #1316