247 Added Missing Endpoints to Reports Lambda - #287
Merged
Conversation
…ts lambda & wrote tests for these
nourshoreibah
approved these changes
Jul 21, 2026
Vaibhav978
reviewed
Jul 26, 2026
| // <<< ROUTES-END | ||
|
|
||
| // GET /reports/{id} | ||
| if ((/^\/reports\/\d+$/.test(normalizedPath) || /^\/\d+$/.test(normalizedPath)) && method === 'GET') { const id = normalizedPath.split('/').pop() as string; |
Contributor
There was a problem hiding this comment.
if I'm not wrong the route matching is duplicated for both GET and DELETE. Maybe you could extract that out?
| if ((/^\/reports\/\d+$/.test(normalizedPath) || /^\/\d+$/.test(normalizedPath)) && method === 'DELETE') { | ||
| const id = normalizedPath.split('/').pop() as string; | ||
|
|
||
| if (!/^\d+$/.test(id)) { |
Contributor
There was a problem hiding this comment.
I believe this is a redundant check, I could be wrong though.
|
|
||
| const authContext = await authenticateRequest(event); | ||
| if (!authContext.isAuthenticated || !authContext.user) { | ||
| return json(401, { message: 'Authentication required' }); |
Contributor
There was a problem hiding this comment.
the auth logic here is duplicated from line 274, maybe we should extract that out?
Vaibhav978
approved these changes
Jul 27, 2026
Vaibhav978
left a comment
Vaibhav978
left a comment
Contributor
There was a problem hiding this comment.
approved pending fixing lambda tests, great job!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
ℹ️ Issue
Closes #247
📝 Description
Added the endpoints GET /reports/{id} and DELETE /reports/id to the reports lambda with authentication. Also wrote tests for these
Briefly list the changes made to the code:
✔️ Verification
Ran jest tests & tested through swagger UI
Provide screenshots of any new components, styling changes, or pages.
Jest:
Unauthorized:
Success:
Not Found:
🏕️ (Optional) Future Work / Notes
Did you notice anything ugly during the course of this ticket? Any bugs, design challenges, or unexpected behavior? Write it down so we can clean it up in a future ticket!