Fix missing PSU checks SUP-30042 - #941
Open
bbayer1 wants to merge 1 commit into
Open
Conversation
bbayer1
marked this pull request as ready for review
July 24, 2026 07:27
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
We noticed, that the netapp_ontap_environment check does not discover controller power supplies for most netapp system types.
This is caused by sensor names that have changed.
Previously the discovery function only matched Sensors beginning with PSU and ending with FAULT.
With this pull request this is changed to starting with PSU and is of sensor type fru.
Please be aware, that this might be an incompatible change, if the power supplies were discovered properly.
Also keep in mind, that we probably have the same issues with controller fans. Maybe you can consider that as well.
The netapp_ontap_psu check also had an issue. It discovered three power supplies, although there are actually two PSUs in a shelf. This is, because the ontap special agent iterates over all shelf frus returned by the api. This also includes the shelf modules. The shelf modules usually have the id 1 and 2. The PSUs have the ids 0 and 1.
This results in the following three services for each shelf.
Power Supply Shelf 0/0
Power Supply Shelf 0/1
Power Supply Shelf 0/2
It should only be
Power Supply Shelf 0/0
Power Supply Shelf 0/1
This is also fixed by this PR