Setting content type and encoding - #5805
Open
ksaye wants to merge 3 commits into
Open
Conversation
Defining the contentType and encoding so we can apply routes to the data and to enable landing it in blob storage not as base64 encoded
Contributor
|
/azp run |
|
Azure Pipelines successfully started running 6 pipeline(s). |
and-rewsmith
reviewed
Nov 8, 2021
and-rewsmith
left a comment
and-rewsmith
left a comment
Contributor
There was a problem hiding this comment.
Not sure as to the context behind this change. What is stopping us from decoding the base64 metrics message?
Looping in @damonbarry for final signoff
Contributor
|
@and-rewsmith @damonberry, @ksaye can correct me if I'm wrong, but this is for IoT Hub routing purposes. |
darobs
approved these changes
Nov 23, 2021
Contributor
Author
Yes for routing purposes. One of our large Oil and Gas customers asked about this. |
Contributor
|
/azp run |
|
Azure Pipelines successfully started running 6 pipeline(s). |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Defining the contentType and encoding so we can apply routes to the data and to enable landing it in blob storage not as base64 encoded
Azure IoT Edge PR checklist:
This checklist is used to make sure that common guidelines for a pull request are followed.
General Guidelines and Best Practices
Testing Guidelines
Draft PRs
Draftmode if it is:Note: We use the kodiakhq bot to merge PRs once the necessary checks and approvals are in place. When it merges a PR, kodiakhq converts the PR title to the commit title, PR description to the commit description, and squashes all the commits in the PR to a single commit. The net effect is that entire PR becomes a single commit. Please follow the best practices mentioned here for the PR title and description