Add rendering regression tests - #255
Merged
Merged
Conversation
eXpl0it3r
force-pushed
the
feature/rendering-regression-tests
branch
3 times, most recently
from
July 28, 2026 12:24
8395ef7 to
25613af
Compare
eXpl0it3r
force-pushed
the
feature/rendering-regression-tests
branch
from
July 28, 2026 13:02
25613af to
b6e0434
Compare
Collaborator
Author
|
It's good enough for now. If we add more regression tests in other ways, the logic should be extracted. We'll also need to ensure a more stable "baseline of fonts". |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
With the upcoming major changes to the underlying parsing via HtmlKit and ExCSS, it's useful to detect potential issues in the rendering.
This adds rendering regression tests based on base-line images and image diffing.