Skip to content

Antalya 25.8, backport of #94359: Allow positional arguments in distributed queries#2070

Open
ianton-ru wants to merge 1 commit into
antalya-25.8from
backport/antalya-25.8/94359
Open

Antalya 25.8, backport of #94359: Allow positional arguments in distributed queries#2070
ianton-ru wants to merge 1 commit into
antalya-25.8from
backport/antalya-25.8/94359

Conversation

@ianton-ru

Copy link
Copy Markdown

Backport of ClickHouse#94359 by @simonmichal
Allow positional arguments in distributed queries

Changelog category (leave one):

  • Bug Fix (user-visible misbehavior in an official stable release)

Changelog entry (a user-readable short description of the changes that goes to CHANGELOG.md):

Allow positional arguments in distributed queries (ClickHouse#94359 by @simonmichal)

Description

In ClickHouse#62289 positional argument substitution was disabled at remote, however in case of a view that can be expanded only in remote this can lead to NOT_AN_AGGREGATE error. This MR enables positional argument substitutions for views.

Tests

Using the reproducer from ClickHouse#89940 :

:) SELECT *
FROM remote('127.0.0.{1|2|3}', currentDatabase(), experiment_by_platform);

SELECT *
FROM remote('127.0.0.{1|2|3}', currentDatabase(), experiment_by_platform)

Query id: c3175e92-73bc-47c4-99cb-0a4235a0d76c

   ┌─sector──┐
1. │ tech    │
2. │ finance │
3. │ health  │
   └─────────┘

3 rows in set. Elapsed: 0.027 sec.

Making sure fix from ClickHouse#62289 is still working:

:) select 0 as x
from remote('127.0.0.{1|2|3}', system.one)
group by x

SELECT 0 AS x
FROM remote('127.0.0.{1|2|3}', system.one)
GROUP BY x

Query id: 846db696-6be2-470d-825b-6cf3deb90a67

   ┌─x─┐
1. │ 0 │
   └───┘

1 row in set. Elapsed: 0.010 sec.

CI/CD Options

Exclude tests:

  • Fast test
  • Integration Tests
  • Stateless tests
  • Stateful tests
  • Performance tests
  • Aarch64 tests
  • All with ASAN
  • All with TSAN
  • All with MSAN
  • All with UBSAN
  • All with Coverage
  • All Regression
  • Disable CI Cache

Regression jobs to run:

  • Fast suites (mostly <1h)
  • Aggregate Functions (2h)
  • Alter (1.5h)
  • Benchmark (30m)
  • ClickHouse Keeper (1h)
  • Iceberg (2h)
  • LDAP (1h)
  • OAuth (5m)
  • Parquet (1.5h)
  • RBAC (1.5h)
  • SSL Server (1h)
  • S3 (2h)
  • S3 Export (2h)
  • Swarms (30m)
  • Tiered Storage (2h)

Backport of ClickHouse#94359 to 25.8.16: Allow positional arguments in distributed queries
@github-actions

Copy link
Copy Markdown

Workflow [PR], commit [a2d7d91]

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants