Skip to content

[Common et all] Fix includes - #17263

Merged
vkucera merged 1 commit into
AliceO2Group:masterfrom
vkucera:iwyu
Jul 30, 2026
Merged

[Common et all] Fix includes#17263
vkucera merged 1 commit into
AliceO2Group:masterfrom
vkucera:iwyu

Conversation

@vkucera

@vkucera vkucera commented Jul 30, 2026

Copy link
Copy Markdown
Collaborator

No description provided.

@github-actions

github-actions Bot commented Jul 30, 2026

Copy link
Copy Markdown

O2 linter results: ❌ 1522 errors, ⚠️ 2096 warnings, 🔕 66 disabled

@github-actions github-actions Bot changed the title Fix includes [Common,DPG,ALICE3,PWGCF,PWGDQ,PWGEM,PWGHF,PWGLF,PWGMM,PWGUD] Fix includes Jul 30, 2026
@vkucera vkucera changed the title [Common,DPG,ALICE3,PWGCF,PWGDQ,PWGEM,PWGHF,PWGLF,PWGMM,PWGUD] Fix includes [Common et all] Fix includes Jul 30, 2026
@vkucera
vkucera marked this pull request as ready for review July 30, 2026 14:57

@amatyja amatyja left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Wit, Thanks for corrections. It is fine from the UD perspective.

@alibuild

Copy link
Copy Markdown
Collaborator

Error while checking build/O2Physics/code-check for 14d9c40 at 2026-07-30 18:28:

## sw/BUILD/O2Physics-code-check-latest/log
--
========== List of issues found ==========
++ echo 'Found 738 errors and 655 warnings.'
Found 738 errors and 655 warnings.
++ [[ 738 -gt 0 ]]
++ cat /sw/BUILD/986c98cdc2a29ae178fc0a0bdfd94a3aa6692145/O2Physics-code-check/errors.txt
ALICE3/Tasks/alice3Multicharm.cxx:53:30: error: initializer for member 'bdtMCharm' is redundant [readability-redundant-member-init,-warnings-as-errors]
ALICE3/Tasks/alice3Multicharm.cxx:54:46: error: initializer for member 'metadata' is redundant [readability-redundant-member-init,-warnings-as-errors]
ALICE3/Tasks/alice3Multicharm.cxx:55:28: error: initializer for member 'ccdbApi' is redundant [readability-redundant-member-init,-warnings-as-errors]
ALICE3/Tasks/alice3-dilepton.cxx:52:8: error: constructor does not initialize these fields: inspdg [cppcoreguidelines-pro-type-member-init,-warnings-as-errors]
ALICE3/Tasks/alice3-dilepton.cxx:595:11: error: do not use 'else' after 'return' [readability-else-after-return,-warnings-as-errors]
ALICE3/Tasks/alice3-prefilterdilepton.cxx:46:10: error: inclusion of deprecated C++ header 'math.h'; consider using 'cmath' instead [modernize-deprecated-headers,-warnings-as-errors]
ALICE3/Tasks/alice3-prefilterdilepton.cxx:54:8: error: constructor does not initialize these fields: inspdg [cppcoreguidelines-pro-type-member-init,-warnings-as-errors]
ALICE3/Tasks/alice3-prefilterdilepton.cxx:127:8: error: constructor does not initialize these fields: inspdg [cppcoreguidelines-pro-type-member-init,-warnings-as-errors]
Common/Tools/PID/pidTPCModule.h:59:10: error: inclusion of deprecated C++ header 'math.h'; consider using 'cmath' instead [modernize-deprecated-headers,-warnings-as-errors]
Common/Tools/PID/pidTPCModule.h:61:1: error: nested namespaces can be concatenated [modernize-concat-nested-namespaces,-warnings-as-errors]
Common/Tools/PID/pidTPCModule.h:100:82: error: implicit conversion 'int' -> 'bool' [readability-implicit-bool-conversion,-warnings-as-errors]
Common/Tools/PID/pidTPCModule.h:101:76: error: implicit conversion 'int' -> 'bool' [readability-implicit-bool-conversion,-warnings-as-errors]
Common/Tools/PID/pidTPCModule.h:106:94: error: implicit conversion 'int' -> 'bool' [readability-implicit-bool-conversion,-warnings-as-errors]
Common/Tools/PID/pidTPCModule.h:178:5: error: do not declare C-style arrays, use 'std::array' instead [modernize-avoid-c-arrays,-warnings-as-errors]
Common/Tools/PID/pidTPCModule.h:187:28: error: do not implicitly decay an array into a pointer; consider using gsl::array_view or an explicit cast instead [cppcoreguidelines-pro-bounds-array-to-pointer-decay,-warnings-as-errors]
Common/Tools/PID/pidTPCModule.h:224:15: error: redundant string initialization [readability-redundant-string-init,-warnings-as-errors]
Common/Tools/PID/pidTPCModule.h:270:13: error: do not use 'compare' to test equality of strings; use the string equality operator instead [readability-string-compare,-warnings-as-errors]
Common/Tools/PID/pidTPCModule.h:274:17: error: do not use 'compare' to test equality of strings; use the string equality operator instead [readability-string-compare,-warnings-as-errors]
Common/Tools/PID/pidTPCModule.h:287:15: error: do not use 'compare' to test equality of strings; use the string equality operator instead [readability-string-compare,-warnings-as-errors]
Common/Tools/PID/pidTPCModule.h:312:45: error: the const qualified parameter 'particle' is copied for each invocation; consider making it a reference [performance-unnecessary-value-param,-warnings-as-errors]
Common/Tools/PID/pidTPCModule.h:350:9: error: the 'empty' method should be used to check for emptiness instead of comparing to an empty object [readability-container-size-empty,-warnings-as-errors]
Common/Tools/PID/pidTPCModule.h:408:7: error: do not use 'else' after 'return' [readability-else-after-return,-warnings-as-errors]
Common/Tools/PID/pidTPCModule.h:417:191: error: use nullptr [modernize-use-nullptr,-warnings-as-errors]
Common/Tools/PID/pidTPCModule.h:417:241: error: use nullptr [modernize-use-nullptr,-warnings-as-errors]
Common/Tools/PID/pidTPCModule.h:426:15: error: the 'empty' method should be used to check for emptiness instead of comparing to an empty object [readability-container-size-empty,-warnings-as-errors]
Common/Tools/PID/pidTPCModule.h:456:13: error: the 'empty' method should be used to check for emptiness instead of comparing to an empty object [readability-container-size-empty,-warnings-as-errors]
Common/Tools/PID/pidTPCModule.h:492:189: error: use nullptr [modernize-use-nullptr,-warnings-as-errors]
Common/Tools/PID/pidTPCModule.h:492:239: error: use nullptr [modernize-use-nullptr,-warnings-as-errors]
Common/Tools/PID/pidTPCModule.h:522:11: error: do not use 'compare' to test equality of strings; use the string equality operator instead [readability-string-compare,-warnings-as-errors]
Common/Tools/PID/pidTPCModule.h:530:9: error: do not use 'compare' to test equality of strings; use the string equality operator instead [readability-string-compare,-warnings-as-errors]
Common/Tools/PID/pidTPCModule.h:778:13: error: do not use 'compare' to test equality of strings; use the string equality operator instead [readability-string-compare,-warnings-as-errors]
Common/Tools/PID/pidTPCModule.h:786:11: error: do not use 'compare' to test equality of strings; use the string equality operator instead [readability-string-compare,-warnings-as-errors]
Common/Tools/PID/pidTPCModule.h:816:16: error: variable 'hadronicRate' is not initialized [cppcoreguidelines-init-variables,-warnings-as-errors]
Common/Tools/PID/pidTPCModule.h:817:13: error: variable 'occupancy' is not initialized [cppcoreguidelines-init-variables,-warnings-as-errors]
Common/Tools/PID/pidTPCModule.h:881:13: error: the 'empty' method should be used to check for emptiness instead of comparing to an empty object [readability-container-size-empty,-warnings-as-errors]
DPG/Tasks/AOTTrack/PID/HMPID/hmpidDeuteron.cxx:89:13: error: member 'rich0' of type 'const int' is const qualified [cppcoreguidelines-avoid-const-or-ref-data-members,-warnings-as-errors]
DPG/Tasks/AOTTrack/PID/HMPID/hmpidDeuteron.cxx:89:24: error: member 'rich1' of type 'const int' is const qualified [cppcoreguidelines-avoid-const-or-ref-data-members,-warnings-as-errors]
DPG/Tasks/AOTTrack/PID/HMPID/hmpidDeuteron.cxx:89:35: error: member 'rich2' of type 'const int' is const qualified [cppcoreguidelines-avoid-const-or-ref-data-members,-warnings-as-errors]
DPG/Tasks/AOTTrack/PID/HMPID/hmpidDeuteron.cxx:89:46: error: member 'rich3' of type 'const int' is const qualified [cppcoreguidelines-avoid-const-or-ref-data-members,-warnings-as-errors]
DPG/Tasks/AOTTrack/PID/HMPID/hmpidDeuteron.cxx:89:57: error: member 'rich4' of type 'const int' is const qualified [cppcoreguidelines-avoid-const-or-ref-data-members,-warnings-as-errors]
DPG/Tasks/AOTTrack/PID/HMPID/hmpidDeuteron.cxx:89:68: error: member 'rich5' of type 'const int' is const qualified [cppcoreguidelines-avoid-const-or-ref-data-members,-warnings-as-errors]
DPG/Tasks/AOTTrack/PID/HMPID/hmpidDeuteron.cxx:89:79: error: member 'rich6' of type 'const int' is const qualified [cppcoreguidelines-avoid-const-or-ref-data-members,-warnings-as-errors]
[0 more errors; see full log]

Full log here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Development

Successfully merging this pull request may close these issues.

4 participants