Skip to content

Add base and root bindings to pre test command - #2032

Open
Ni-g-3l wants to merge 3 commits into
AcademySoftwareFoundation:mainfrom
Ni-g-3l:feat-add-missing-base-root-pre-test-cmd
Open

Add base and root bindings to pre test command#2032
Ni-g-3l wants to merge 3 commits into
AcademySoftwareFoundation:mainfrom
Ni-g-3l:feat-add-missing-base-root-pre-test-cmd

Conversation

@Ni-g-3l

@Ni-g-3l Ni-g-3l commented Oct 20, 2025

Copy link
Copy Markdown
Contributor

Hey !

I found that on pre_test_command, "base" and "root" bindings were missing.

They are still available with "{this.base}" or "{this.root}", however I think it's important to keep consistency between available callback inside package.py

Feel free to comment or ask me question :)

@Ni-g-3l
Ni-g-3l requested a review from a team as a code owner October 20, 2025 16:06
@codecov

codecov Bot commented Oct 20, 2025

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 61.33%. Comparing base (5c598c5) to head (816c9ae).

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #2032      +/-   ##
==========================================
+ Coverage   61.29%   61.33%   +0.04%     
==========================================
  Files         164      164              
  Lines       20568    20570       +2     
  Branches     3575     3575              
==========================================
+ Hits        12607    12617      +10     
+ Misses       7089     7081       -8     
  Partials      872      872              

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@Ni-g-3l
Ni-g-3l force-pushed the feat-add-missing-base-root-pre-test-cmd branch from ddd2a1a to 57030ac Compare October 21, 2025 07:39
@linux-foundation-easycla

linux-foundation-easycla Bot commented Jul 17, 2026

Copy link
Copy Markdown

CLA Signed
The committers listed above are authorized under a signed CLA.

@maxnbk

maxnbk commented Jul 17, 2026

Copy link
Copy Markdown
Contributor

@Ni-g-3l , I've added tests to the PR that it would be nice if you could evaluate yourself, and if you could sign the CLA, we would be able to move forward merging this PR I believe.

@Ni-g-3l
Ni-g-3l force-pushed the feat-add-missing-base-root-pre-test-cmd branch 3 times, most recently from cf719b5 to 365e9c2 Compare July 19, 2026 10:55
@Ni-g-3l

Ni-g-3l commented Jul 19, 2026

Copy link
Copy Markdown
Contributor Author

Hi ! thanks ! I signed CLA but I don't know why it still doesn't work :/

@JeanChristopheMorinPerso

Copy link
Copy Markdown
Member

@Ni-g-3l it looks like commit 9631300 was committed under a different email address. I think you can fix this using this:

git rebase --onto HEAD~2 --exec "git commit --amend --reset-author --no-edit" HEAD~2

(make sure that your git config is configured correctly. You can check using git config user.email and git config user.name).

@JeanChristopheMorinPerso

Copy link
Copy Markdown
Member

Also, it might be worth rebasing on main. I think the failure to build the docs is related to the branch being tool old. Lastly, I think we need to update the docs to reflect that there are new variables available: https://rez.readthedocs.io/en/stable/package_commands.html#pre-test-commands.

@maxnbk

maxnbk commented Aug 1, 2026

Copy link
Copy Markdown
Contributor

@Ni-g-3l Just re-pinging to see if Jean-Christophe's command can help you with the CLA issue. I'd love to get this merged.

Ni-g-3l added 2 commits August 2, 2026 14:43
Signed-off-by: Nig3l <cots.max@gmail.com>
Add a pre_test_commands function to the testing_obj fixture package
that uses the root and base bindings, and a test entry that verifies
the bindings are available. Update affected test counts in test_test.py.

Signed-off-by: Nig3l <cots.max@gmail.com>
@Ni-g-3l
Ni-g-3l force-pushed the feat-add-missing-base-root-pre-test-cmd branch from 365e9c2 to c25be22 Compare August 2, 2026 12:43
Signed-off-by: Nig3l <cots.max@gmail.com>
@Ni-g-3l
Ni-g-3l force-pushed the feat-add-missing-base-root-pre-test-cmd branch from 0463ba9 to 816c9ae Compare August 2, 2026 14:03
@Ni-g-3l

Ni-g-3l commented Aug 2, 2026

Copy link
Copy Markdown
Contributor Author

Should be okay now :) sorry for late responding I was busy last week :)

@JeanChristopheMorinPerso JeanChristopheMorinPerso added this to the Next milestone Aug 9, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants