Add base and root bindings to pre test command - #2032
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #2032 +/- ##
==========================================
+ Coverage 61.29% 61.33% +0.04%
==========================================
Files 164 164
Lines 20568 20570 +2
Branches 3575 3575
==========================================
+ Hits 12607 12617 +10
+ Misses 7089 7081 -8
Partials 872 872 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
ddd2a1a to
57030ac
Compare
|
@Ni-g-3l , I've added tests to the PR that it would be nice if you could evaluate yourself, and if you could sign the CLA, we would be able to move forward merging this PR I believe. |
cf719b5 to
365e9c2
Compare
|
Hi ! thanks ! I signed CLA but I don't know why it still doesn't work :/ |
|
@Ni-g-3l it looks like commit 9631300 was committed under a different email address. I think you can fix this using this: (make sure that your git config is configured correctly. You can check using |
|
Also, it might be worth rebasing on main. I think the failure to build the docs is related to the branch being tool old. Lastly, I think we need to update the docs to reflect that there are new variables available: https://rez.readthedocs.io/en/stable/package_commands.html#pre-test-commands. |
|
@Ni-g-3l Just re-pinging to see if Jean-Christophe's command can help you with the CLA issue. I'd love to get this merged. |
Signed-off-by: Nig3l <cots.max@gmail.com>
Add a pre_test_commands function to the testing_obj fixture package that uses the root and base bindings, and a test entry that verifies the bindings are available. Update affected test counts in test_test.py. Signed-off-by: Nig3l <cots.max@gmail.com>
365e9c2 to
c25be22
Compare
Signed-off-by: Nig3l <cots.max@gmail.com>
0463ba9 to
816c9ae
Compare
|
Should be okay now :) sorry for late responding I was busy last week :) |
Hey !
I found that on pre_test_command, "base" and "root" bindings were missing.
They are still available with "{this.base}" or "{this.root}", however I think it's important to keep consistency between available callback inside package.py
Feel free to comment or ask me question :)