Restore Engram defaults in RLConfig - #4621
Merged
copybara-service[bot] merged 1 commit intoJul 27, 2026
Merged
Conversation
|
Caution The consumer version of Gemini Code Assist on GitHub has been sunset. All code review activity has officially ceased. |
csgoogle
force-pushed
the
gemma4-post-training
branch
from
July 27, 2026 08:28
d70fdb0 to
23aa9f8
Compare
csgoogle
marked this pull request as ready for review
July 27, 2026 08:29
csgoogle
requested review from
abhinavclemson,
bvandermoon,
gobbleturk and
khatwanimohit
as code owners
July 27, 2026 08:29
|
Caution The consumer version of Gemini Code Assist on GitHub has been sunset. All code review activity has officially ceased. |
csgoogle
requested review from
A9isha,
NuojCheng,
RissyRan,
SurbhiJainUSC,
aireenmei,
darisoy,
dipannita08,
gagika,
hengtaoguo,
huytransformer,
igorts-git,
jiangjy1982,
richjames0,
shralex,
suexu1025,
vipannalla and
xibinliu
as code owners
July 27, 2026 08:29
csgoogle
marked this pull request as draft
July 27, 2026 08:29
csgoogle
marked this pull request as ready for review
July 27, 2026 08:30
|
Caution The consumer version of Gemini Code Assist on GitHub has been sunset. All code review activity has officially ceased. |
SurbhiJainUSC
approved these changes
Jul 27, 2026
Codecov Report✅ All modified and coverable lines are covered by tests. 📢 Thoughts on this report? Let us know! |
abhinavclemson
approved these changes
Jul 27, 2026
copybara-service
Bot
merged commit Jul 27, 2026
40aaa08
into
AI-Hypercomputer:main
57 of 63 checks passed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Engramconfiguration mixin toRLConfigRoot cause
The dedicated
RLConfigschema omittedEngramwhen RL configuration was split fromMaxTextConfig. Shared decoder code readsengram_layerseven when Engram is disabled, so RL models need those fields to satisfy the decoder configuration contract.This change supplies the existing disabled defaults (
engram_layers=[]andengram_max_ngram_size=3). It does not enable Engram or change Gemma 4 weights, architecture, or numerics.Tests
JAX_PLATFORMS=cpu pytest -q tests/post_training/unit/train_rl_test.py -k test_rl_config_includes_decoder_engram_defaults— passedgit diff --check— passedChecklist
Before submitting this PR, please make sure (put X in square brackets):
gemini-reviewlabel.