Skip to content

refactor(standards): remove the AuthSingleSigAcl auth component - #3462

Merged
bobbinth merged 3 commits into
0xMiden:nextfrom
mmagician:mmagician-claude/remove-singlesig-acl
Aug 3, 2026
Merged

refactor(standards): remove the AuthSingleSigAcl auth component#3462
bobbinth merged 3 commits into
0xMiden:nextfrom
mmagician:mmagician-claude/remove-singlesig-acl

Conversation

@mmagician

@mmagician mmagician commented Aug 2, 2026

Copy link
Copy Markdown
Collaborator

Closes #3360.

as per title

Its exempt-procedure-list mechanism let fee-charging accounts be
drained: anyone could call an exempt procedure without a signature,
but the account still paid the transaction fee. The team decided to
remove the component rather than fix it now (see issue discussion).

The plain AuthSingleSig component (every call requires a signature)
remains available and now backs the "singlesig user faucet" factories.

Closes 0xMiden#3360
Comment thread crates/miden-standards/src/note/burn.rs Outdated
@mmagician
mmagician marked this pull request as ready for review August 2, 2026 12:57
claude and others added 2 commits August 2, 2026 13:00
Per review feedback: the struct-level doc comment already covers the
network-execution caveat; the internal conversion comment didn't need
the same rewording.
@mmagician mmagician added the standards Related to standard note scripts or account components label Aug 2, 2026
@mmagician
mmagician requested a review from bobbinth August 2, 2026 15:19

@bobbinth bobbinth left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! Thank you!

@bobbinth
bobbinth added this pull request to the merge queue Aug 3, 2026
Merged via the queue into 0xMiden:next with commit a1214f9 Aug 3, 2026
17 checks passed
@mmagician
mmagician deleted the mmagician-claude/remove-singlesig-acl branch August 4, 2026 08:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

standards Related to standard note scripts or account components

Projects

None yet

Development

Successfully merging this pull request may close these issues.

SinglesigACL's excempt procedures may lead to draining the vault

3 participants