Skip to content

Commit 61a3e35

Browse files
jeffreyavenclaude
andcommitted
Point google tests at project resource instead of deleted bucket
The gcs bucket stackql-public-releases used by the google test steps no longer exists, so the queries returned no rows and the tests failed. Switch them to google.cloudresourcemanager.projects (projectsId = 'stackql'), a stable resource, asserting projectId/displayName/state. Values verified live: projectId=stackql, displayName=stackql, state=ACTIVE. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
1 parent 5a91a98 commit 61a3e35

4 files changed

Lines changed: 11 additions & 14 deletions

File tree

.github/workflows/stackql-assert-test.yml

Lines changed: 4 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -33,10 +33,9 @@ jobs:
3333
uses: ./
3434
with:
3535
test_query: |
36-
SELECT name, location, locationType
37-
FROM google.storage.buckets
38-
WHERE project = 'stackql'
39-
AND name = 'stackql-public-releases';
36+
SELECT projectId, displayName, state
37+
FROM google.cloudresourcemanager.projects
38+
WHERE projectsId = 'stackql';
4039
expected_rows: 1
4140
env:
4241
GOOGLE_CREDENTIALS: ${{ secrets.GOOGLE_CREDENTIALS }}
@@ -48,7 +47,7 @@ jobs:
4847
uses: ./
4948
with:
5049
test_query_file_path: './.github/workflows/workflow_scripts/google-example.iql'
51-
expected_results_str: '[{"location":"US","locationType":"multi-region","name":"stackql-public-releases"}]'
50+
expected_results_str: '[{"displayName":"stackql","projectId":"stackql","state":"ACTIVE"}]'
5251
env:
5352
GOOGLE_CREDENTIALS: ${{ secrets.GOOGLE_CREDENTIALS }}
5453

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1 +1 @@
1-
[{"location":"US","locationType":"multi-region","name":"stackql-public-releases"}]
1+
[{"displayName":"stackql","projectId":"stackql","state":"ACTIVE"}]

.github/workflows/workflow_scripts/google-example-inline-jsonnet.iql

Lines changed: 3 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -4,7 +4,6 @@ local project = std.extVar("GOOGLE_PROJECT");
44
project: project,
55
}
66
>>>
7-
SELECT name, location, locationType
8-
FROM google.storage.buckets
9-
WHERE project = '{{ .project }}'
10-
AND name = 'stackql-public-releases';
7+
SELECT projectId, displayName, state
8+
FROM google.cloudresourcemanager.projects
9+
WHERE projectsId = '{{ .project }}';
Lines changed: 3 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -1,4 +1,3 @@
1-
SELECT name, location, locationType
2-
FROM google.storage.buckets
3-
WHERE project = 'stackql'
4-
AND name = 'stackql-public-releases';
1+
SELECT projectId, displayName, state
2+
FROM google.cloudresourcemanager.projects
3+
WHERE projectsId = 'stackql';

0 commit comments

Comments
 (0)