Skip to content

Commit 308b32c

Browse files
xnotoclaude
andauthored
docs: purge OpenShift-era framing from AGENTS (#5)
## Summary \`AGENTS.md\` claimed inputs and pointed at runbooks that don't match the current shared workflow: - \`container\` input does not exist on \`opentofu.yml\` and shouldn't — the \`arc-tf\` runner pod IS the \`tfroot-runner\` image; nesting a container would double-wrap. - The note about \`tfroot-libvirt\` overriding \`container\` to use the internal OpenShift registry referred to a path that's gone. - The \"manifest unknown\" failure mode pointed at the deleted Pull workflow on \`images\` (which used to import to OpenShift's internal registry). - The \`runs-on\` default in the table was \`ubuntu-latest\`; the actual default is \`arc-tf\`. This PR rewrites those sections to describe what actually exists. 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-authored-by: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
1 parent d2e577e commit 308b32c

1 file changed

Lines changed: 9 additions & 10 deletions

File tree

AGENTS.md

Lines changed: 9 additions & 10 deletions
Original file line numberDiff line numberDiff line change
@@ -14,8 +14,8 @@ Agents are authorized to push directly to `main` in this repository.
1414

1515
Reusable workflow for OpenTofu/Terraform root module repositories (`tfroot-*`). It:
1616

17-
1. Fetches canonical pre-commit config from `makeitworkcloud/images` repo
18-
2. Runs pre-commit tests using the `tfroot-runner` container image
17+
1. Fetches the canonical pre-commit config from `makeitworkcloud/images`
18+
2. Runs pre-commit on the `arc-tf` runner pod (which is itself the `tfroot-runner` image — no nested `container:` block)
1919
3. Posts plan output as PR comments
2020
4. Applies on merge to main
2121

@@ -25,20 +25,19 @@ Reusable workflow for OpenTofu/Terraform root module repositories (`tfroot-*`).
2525

2626
| Input | Default | Description |
2727
|-------|---------|-------------|
28-
| `runs-on` | `ubuntu-latest` | Runner label |
29-
| `container` | `ghcr.io/makeitworkcloud/tfroot-runner:latest` | Container image |
30-
| `setup-ssh` | `false` | Whether to setup SSH keys |
31-
| `environment` | `production` | Environment for apply job |
28+
| `runs-on` | `arc-tf` | Runner label — the in-cluster ARC scale set whose pods run the tfroot-runner image |
29+
| `setup-ssh` | `false` | Provision an SSH key + known_hosts for libvirt-style root modules |
30+
| `environment` | `production` | Environment for the apply job |
3231

33-
**Note:** `tfroot-libvirt` overrides `container` to use the internal OpenShift registry because it requires SSH access to libvirt hosts from a self-hosted runner.
32+
There is no `container` input. The `arc-tf` runner pod IS the image, so adding `container:` on top would nest a container inside a container — don't do it.
3433

3534
## Failure Modes
3635

3736
### "manifest unknown" or image pull failures
3837

39-
The `tfroot-runner` image doesn't exist yet. Check:
40-
1. Did the `images` repo Build workflow succeed?
41-
2. Did the `images` repo Pull workflow import to OpenShift? (check logs for actual metadata, not "Unable to connect" errors)
38+
The `tfroot-runner` image is missing or the tag is wrong. Check:
39+
1. Did the `images` repo `buildah` workflow succeed for the latest commit?
40+
2. Is the runner template image tag in `kustomize-cluster/workloads/arc/arc-tf-application.yaml` resolvable on GHCR (`ghcr.io/makeitworkcloud/tfroot-runner:latest`)?
4241

4342
### Pre-commit hook failures
4443

0 commit comments

Comments
 (0)