^ d I've changed my mind about not asserting inside inspectChangingView

Author: jonreid

README.md

@@ -92,35 +92,7 @@ func test_incrementOnce_withTestableView() throws {
 <!-- endSnippet -->
 
 That's much simpler, hiding the boilerplate that isn't part of the test-specific intent.
-
-### Improvements for safety and scannability
-
-I avoid assertions inside closures. If something goes wrong with the infrastructure and the closure doesn't run, will the test fail? Sometimes the infrastructure ensures this, sometimes it doesn't.
-
-So I like to set up an optional variable, capture the value inside the closure, then check the result on the outside.
-
-<!-- snippet: scannable -->
-<a id='snippet-scannable'></a>
-```swift
-@MainActor
-func test_incrementOnce_scannable() throws {
-    var sut = ContentView()
-    var count: String?
-
-    inspectChangingView(&sut) { view in
-        try view.find(viewWithAccessibilityIdentifier: "increment").button().tap()
-        count = try view.find(viewWithAccessibilityIdentifier: "count").text().string()
-    }
-
-    XCTAssertEqual(count, "1")
-}
-```
-<sup><a href='/SampleApp/CounterTests/ContentViewTests.swift#L42-L55' title='Snippet source file'>snippet source</a> | <a href='#snippet-scannable' title='Start of snippet'>anchor</a></sup>
-<!-- endSnippet -->
-
-That lets us add blank lines to separate the Arrange/Act/Assert sections of the test.
-
-Now we have a SwiftUI unit test that is safer, and easier to scan!
+Now we have an expressive SwiftUI unit test!
 
 ### Acknowledgements
 

SampleApp/Counter/ContentView.swift

@@ -12,6 +12,7 @@ struct ContentView: TestableView {
             }
             .accessibilityIdentifier("increment")
             .padding()
+            GreetingView()
         }
         // begin-snippet: trigger
         .onAppear { self.viewInspectorHook?(self) }

SampleApp/CounterTests/ContentViewTests.swift

@@ -31,26 +31,13 @@ final class ContentViewTests: XCTestCase {
     @MainActor
     func test_incrementOnce_withTestableView() throws {
         var sut = ContentView()
+
         inspectChangingView(&sut) { view in
             try view.find(viewWithAccessibilityIdentifier: "increment").button().tap()
+
             let count = try view.find(viewWithAccessibilityIdentifier: "count").text().string()
             XCTAssertEqual(count, "1")
         }
     }
     // end-snippet
-
-    // begin-snippet: scannable
-    @MainActor
-    func test_incrementOnce_scannable() throws {
-        var sut = ContentView()
-        var count: String?
-
-        inspectChangingView(&sut) { view in
-            try view.find(viewWithAccessibilityIdentifier: "increment").button().tap()
-            count = try view.find(viewWithAccessibilityIdentifier: "count").text().string()
-        }
-
-        XCTAssertEqual(count, "1")
-    }
-    // end-snippet
 }