Linting

Author: geraintwhite

data.py

@@ -1,4 +1,4 @@
-from colours import *
+from colours import DARK, BOLD, DARK_GRAY, YELLOW, RED, WHITE
 from console import supported_chars
 
 

events.py

@@ -40,4 +40,4 @@ def boom(server, x, y):
 
     server.splash_damage(x, y, radius*2, blast_strength/3)
 
-    return new_blocks
+    return new_blocks

items.py

@@ -66,4 +66,4 @@ def items_to_render_objects(items, x, offset):
 
         objects.append(object_)
 
-    return objects
+    return objects

main.py

@@ -80,7 +80,6 @@ def setdown():
 
 def game(server, settings, benchmarks):
     dt = 0  # Tick
-    df = 0  # Frame
     dc = 0  # Cursor
     ds = 0  # Selector
     dpos = False
@@ -286,14 +285,14 @@ def game(server, settings, benchmarks):
             events += new_events
 
             new_blocks = {}
-            for i in range(int(dt)):
+            for _ in range(int(dt)):
                 new_blocks.update(process_events(events, server))
             if new_blocks:
                 server.set_blocks(new_blocks)
 
             # If no block below, kill player
             try:
-                block = server.map_[x][y+1]
+                _ = server.map_[x][y+1]
             except IndexError:
                 alive = False
 

mobs.py

@@ -30,7 +30,7 @@ def update(mobs, players, map_, last_tick):
     new_items = {}
 
     for mob_id, mob in mobs.items():
-        mx, my, x_vel = mob['x'], mob['y'], mob['x_vel']
+        mx, my = mob['x'], mob['y']
 
         if mob['health'] <= 0:
             removed_mobs.append(mob_id)
@@ -64,7 +64,7 @@ def update(mobs, players, map_, last_tick):
 
 
 def spawn(mobs, players, map_, x_start_range, y_start_range, x_end_range, y_end_range):
-    log("spawning", x_start_range, x_end_range, m='mobs');
+    log('spawning', x_start_range, x_end_range, m='mobs')
 
     n_mobs_to_spawn = random.randint(0, 5) if random.random() < mob_rate else 0
     new_mobs = {}

network.py

@@ -53,7 +53,7 @@ def receive(sock):
         d = bytes()
 
         try:
-            for i in range(length // bufsize):
+            for _ in range(length // bufsize):
                 d += sock.recv(bufsize)
                 time.sleep(0.001)
             d += sock.recv(length % bufsize)
@@ -107,7 +107,7 @@ def start(data_handler, port):
     HOST, PORT = '0.0.0.0', int(port)
 
     server = ThreadedTCPServer((HOST, PORT), requestHandlerFactory(data_handler))
-    ip, port = server.server_address
+    _, port = server.server_address
 
     # Start a thread with the server -- that thread will then start one
     # more thread for each request

pathfinding.py

@@ -33,4 +33,4 @@ def pathfind_towards_delta(entity, delta, map_):
 
       updated = True
 
-  return updated, kill_entity
+  return updated, kill_entity

player.py

@@ -44,7 +44,7 @@ def get_pos_delta_on_input(inp, map_, x, y, jump, flight):
     return dx, dy, jump
 
 
-def get_pos_delta(dx, x, y, map_, flight):
+def get_pos_delta(dx, x, y, map_, flight=False):
 
     player_slice = map_[x]
 

render.py

@@ -1,7 +1,7 @@
 from math import pi, cos, sin, sqrt, modf, radians
 
-from colours import *
-from console import *
+from colours import colour_str, uncolour_str, rgb, round_to_palette, lightness, bold, RED, CYAN, BLUE
+from console import supported_chars, DEBUG, POS_STR, CLS_END_LN
 from data import lighting, world_gen, blocks, timings
 from terrain import is_solid
 
@@ -104,7 +104,6 @@ def obj_pixel(x, y, objects):
 
     if object_:
         model = object_['model']
-        width = len(model)
         height = len(model[0])
 
         dx = x - object_['x']
@@ -240,7 +239,7 @@ def get_light_colour(x, y, world_x, map_, slice_heights, lights, colour_behind,
 
         else:
 
-            light = CYAN if any(map(lambda l: lit(world_x, x, y, l) < 1, lights)) else hsv_to_rgb(colour_behind)
+            light = CYAN if any(map(lambda l: lit(world_x + x, y, l) < 1, lights)) else hsv_to_rgb(colour_behind)
 
     return light
 

render_interface.py

@@ -55,4 +55,4 @@ def get_light_level(*args):
         log('Not implemented: Python get_light_level function', m='warning')
 
     log('{}'.format(result), m='lighting')
-    return result
+    return result