Skip to content

Commit 46a11e3

Browse files
committed
docs(release): correct publish:testing guidance in runbook
publish:testing is NOT a dry run — lerna publish runs npm publish (testing dist-tag); --no-push only suppresses git. It also only runs from 'stable' due to the allowBranch guard. Replace the §4 'dry run' step with a safe, non-publishing 'lerna version --no-push --no-git-tag-version --allow-branch' smoke test, and document the bump-from-commits behavior. Ref: FW-7569
1 parent 532a6d3 commit 46a11e3

1 file changed

Lines changed: 18 additions & 5 deletions

File tree

.github/RELEASING.md

Lines changed: 18 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -136,13 +136,26 @@ npm run test
136136
# Drift guard: a green build of @ionic/discover (no publisher.ts "broadcast"
137137
# TS2322) confirms the netmask@2.0.2 + @types/netmask@2.0.5 pins resolved.
138138

139-
# 4. Safe release dry-run — no tag, no push, no publish
140-
npm run publish:testing
139+
# 4. Non-publishing version smoke test — exercises the Lerna 5 version path
140+
# WITHOUT publishing to npm or touching git. `--allow-branch` overrides the
141+
# lerna.json `allowBranch: stable` guard for this one local run.
142+
npx lerna version --conventional-commits --no-push --no-git-tag-version \
143+
--allow-branch "$(git branch --show-current)" --yes
144+
git checkout -- . # discard the version/CHANGELOG file writes lerna just made
141145
```
142146

143-
`publish:testing` is the safest smoke test — it exercises the Lerna 5 publish
144-
path without tagging or pushing. **Run it before the first live v8 cut** to
145-
confirm the 3 → 5 upgrade behaves (flag/config changes across Lerna 4 and 5).
147+
> **`npm run publish:testing` is NOT a dry run — it publishes to npm.**
148+
> `lerna publish` runs an `npm publish` (the `@ionic/*` packages under the
149+
> `testing` dist-tag); `--no-push`/`--no-git-tag-version` only suppress *git*
150+
> actions, not the registry publish. It also only runs from `stable` (the
151+
> `allowBranch` guard). Use step 4 above for a safe local check. Run
152+
> `publish:testing` only when you actually intend to push a `testing` prerelease
153+
> to npm, with valid npm credentials.
154+
155+
The step-4 smoke test also reveals the **computed version bump** from the
156+
branch's conventional commits. Note it will show a `patch`/`minor` bump until
157+
the branch carries breaking-change commits (`feat!:` / `BREAKING CHANGE:`) —
158+
those, not `BREAKING.md`, are what make `@ionic/cli` land on `8.0.0` (see §1).
146159

147160
> **Known platform note (pre-existing, unrelated to the release tooling):** on
148161
> **Windows**, one test in `integrations/cordova` asserts POSIX (`/`) path

0 commit comments

Comments
 (0)