Skip to content

Commit d0c8144

Browse files
committed
ci: drop workflow-perms cap on reusable-workflow callers
codeql.yml, pr-checks.yml and unit-tests.yml only call reusable workflows. A caller's workflow-level permissions cap the GITHUB_TOKEN for the called workflow, which cannot request more than the caller grants. The contents: read block here was stripping scopes the callees need: - codeQLworkflow.yml needs security-events: write and actions: read to upload CodeQL results to Code Scanning (the issue @akurtakov asked to correct) - verifyFreezePeriod.yml needs issues: read - checkMergeCommits.yml needs pull-requests: read - publishTestResults.yml needs checks: write, pull-requests: write, issues: read and actions: read Revert the permissions block on these three reusable-only callers; each reusable workflow already declares its own least-privilege permissions. The contents: read additions on the remaining workflows in this PR are kept. Signed-off-by: Arpit Jain <arpitjain099@gmail.com>
1 parent 59e3c2c commit d0c8144

3 files changed

Lines changed: 0 additions & 9 deletions

File tree

.github/workflows/codeql.yml

Lines changed: 0 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -8,9 +8,6 @@ on:
88
schedule:
99
- cron: '15 8 * * 1'
1010

11-
permissions:
12-
contents: read
13-
1411
jobs:
1512
callCodeQLworkflow:
1613
uses: eclipse-platform/eclipse.platform.releng.aggregator/.github/workflows/codeQLworkflow.yml@master

.github/workflows/pr-checks.yml

Lines changed: 0 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -9,9 +9,6 @@ on:
99
pull_request:
1010
branches: [ master ]
1111

12-
permissions:
13-
contents: read
14-
1512
jobs:
1613
check-freeze-period:
1714
uses: eclipse-platform/eclipse.platform.releng.aggregator/.github/workflows/verifyFreezePeriod.yml@master

.github/workflows/unit-tests.yml

Lines changed: 0 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -6,9 +6,6 @@ on:
66
types:
77
- completed
88

9-
permissions:
10-
contents: read
11-
129
jobs:
1310
check:
1411
uses: eclipse-platform/eclipse.platform.releng.aggregator/.github/workflows/publishTestResults.yml@master

0 commit comments

Comments
 (0)