MCU protocol for LCD does not use newline

[tschiemer]

https://github.com/celtera/libremidi/blob/master/include%2Flibremidi%2Fprotocols%2Fremote_control.hpp#L400

Two newlines are always inserted replacing any characters sent.

Hardware maps characters automatically on the two lines.

7 chars per channel, 8 channels -> 56
Char 56 and 112 shouldnt be overwritten.

Also see
https://htlab.net/computer/protocol/mackie-control/MackieControlProtocol_EN.pdf

This might be needed for touchOSC which I guess does not wrap automatically.

Would it make sense to make this either devicetype dependent or as a protocol option?

By the way, thanks for the implementation!
I'm aiming to extend it a bit to contol x-touch surfaces :)

Ps. Also Im not sure why this 'N' variable is needed along with the safeguard min function. Isnt the conditional right before doing the safeguard, couldnt 'len' be used directly?
https://github.com/celtera/libremidi/blob/master/include%2Flibremidi%2Fprotocols%2Fremote_control.hpp#L395

[jcelerier]

hello! thanks for testing this!

This might be needed for touchOSC which I guess does not wrap automatically.

yes exactly, my only MCU-compatible hardware does not have a LCD so my only way to test it was with the touchosc patch which wanted those \n.
So yes, I think a protocol option would make sense here (or.. just fixing the touchosc patch so that it matches real hardware ideally?)

Isnt the conditional right before doing the safeguard, couldnt 'len' be used directly?

yeah absolutely, it could be len, I think it's just a leftover of multiple stages of development. Please make a small PR !

[tschiemer]

Thanks for your response!

Mhm, I'd spontanously agree that touchOSC should be fixed up - if possible. I'd think such an soft-option might be a way out but optimally shouldn't be the solution.
But having a look at touchOSC isnt my top priority..

Happy to make a pull request, but I'd combine it with bit of a bigger addition (new example and remote protocol additions/changes) - if that' s fine for you?

Still in the dev process, but also see tschiemer:feature/mackie-xt_xtouch

edit: speaking of which, how free am I to make some refactorings of the remote protocol code? should I just do and then you' ll see?

[jcelerier]

yes, feel free to do a larger PR! anything that improves hardware support is welcome, your branch looks fine ! :)