Skip to content

Commit b260f13

Browse files
jnthntatumcopybara-github
authored andcommitted
Add migration guide for CelValue -> cel::Value.
Closes #1520 PiperOrigin-RevId: 947764914
1 parent e5b3805 commit b260f13

17 files changed

Lines changed: 1088 additions & 772 deletions

codelab/BUILD

Lines changed: 49 additions & 47 deletions
Original file line numberDiff line numberDiff line change
@@ -44,18 +44,22 @@ cc_library(
4444
"nobuilder",
4545
],
4646
deps = [
47-
"//eval/public:activation",
48-
"//eval/public:builtin_func_registrar",
49-
"//eval/public:cel_expr_builder_factory",
50-
"//eval/public:cel_expression",
51-
"//eval/public:cel_options",
52-
"//eval/public:cel_value",
47+
"//checker:validation_result",
48+
"//common:ast",
49+
"//common:minimal_descriptor_pool",
50+
"//common:value",
51+
"//compiler",
52+
"//compiler:compiler_factory",
53+
"//compiler:standard_library",
5354
"//internal:status_macros",
54-
"//parser",
55+
"//runtime",
56+
"//runtime:activation",
57+
"//runtime:runtime_builder",
58+
"//runtime:runtime_options",
59+
"//runtime:standard_runtime_builder_factory",
5560
"@com_google_absl//absl/status",
5661
"@com_google_absl//absl/status:statusor",
5762
"@com_google_absl//absl/strings",
58-
"@com_google_cel_spec//proto/cel/expr:syntax_cc_proto",
5963
"@com_google_protobuf//:protobuf",
6064
],
6165
)
@@ -76,22 +80,25 @@ cc_library(
7680
srcs = ["exercise2.cc"],
7781
hdrs = ["exercise2.h"],
7882
deps = [
79-
":cel_compiler",
83+
"//checker:type_checker_builder",
84+
"//checker:validation_result",
85+
"//common:ast",
86+
"//common:decl",
87+
"//common:type",
88+
"//common:value",
8089
"//compiler",
8190
"//compiler:compiler_factory",
8291
"//compiler:standard_library",
83-
"//eval/public:activation",
84-
"//eval/public:builtin_func_registrar",
85-
"//eval/public:cel_expr_builder_factory",
86-
"//eval/public:cel_expression",
87-
"//eval/public:cel_options",
88-
"//eval/public:cel_value",
8992
"//internal:status_macros",
93+
"//runtime",
94+
"//runtime:activation",
95+
"//runtime:bind_proto_to_activation",
96+
"//runtime:runtime_builder",
97+
"//runtime:runtime_options",
98+
"//runtime:standard_runtime_builder_factory",
9099
"@com_google_absl//absl/status",
91100
"@com_google_absl//absl/status:statusor",
92101
"@com_google_absl//absl/strings",
93-
"@com_google_cel_spec//proto/cel/expr:checked_cc_proto",
94-
"@com_google_cel_spec//proto/cel/expr:syntax_cc_proto",
95102
"@com_google_googleapis//google/rpc/context:attribute_context_cc_proto",
96103
"@com_google_protobuf//:protobuf",
97104
],
@@ -125,42 +132,30 @@ cc_test(
125132
)
126133

127134
cc_library(
128-
name = "cel_compiler",
129-
hdrs = ["cel_compiler.h"],
135+
name = "checked_expr_conversion_example",
136+
hdrs = ["checked_expr_conversion_example.h"],
130137
deps = [
131-
"//checker:validation_result",
138+
"//common:ast",
132139
"//common:ast_proto",
133-
"//compiler",
134140
"//internal:status_macros",
135-
"@com_google_absl//absl/status",
136141
"@com_google_absl//absl/status:statusor",
137-
"@com_google_absl//absl/strings",
138142
"@com_google_cel_spec//proto/cel/expr:checked_cc_proto",
139143
],
140144
)
141145

142146
cc_test(
143-
name = "cel_compiler_test",
144-
srcs = ["cel_compiler_test.cc"],
147+
name = "checked_expr_conversion_example_test",
148+
srcs = ["checked_expr_conversion_example_test.cc"],
145149
deps = [
146-
":cel_compiler",
147-
"//common:decl",
148-
"//common:type",
150+
":checked_expr_conversion_example",
151+
"//checker:validation_result",
152+
"//common:ast",
149153
"//compiler",
150154
"//compiler:compiler_factory",
151155
"//compiler:standard_library",
152-
"//eval/public:activation",
153-
"//eval/public:activation_bind_helper",
154-
"//eval/public:builtin_func_registrar",
155-
"//eval/public:cel_expr_builder_factory",
156-
"//eval/public:cel_function_adapter",
157-
"//eval/public:cel_value",
158-
"//eval/public/testing:matchers",
159156
"//internal:testing",
160-
"@com_google_absl//absl/log:absl_check",
161-
"@com_google_absl//absl/status",
162157
"@com_google_absl//absl/status:status_matchers",
163-
"@com_google_googleapis//google/rpc/context:attribute_context_cc_proto",
158+
"@com_google_cel_spec//proto/cel/expr:checked_cc_proto",
164159
"@com_google_protobuf//:protobuf",
165160
],
166161
)
@@ -170,22 +165,27 @@ cc_library(
170165
srcs = ["exercise4.cc"],
171166
hdrs = ["exercise4.h"],
172167
deps = [
173-
":cel_compiler",
168+
"//checker:type_checker_builder",
169+
"//checker:validation_result",
170+
"//common:ast",
171+
"//common:decl",
172+
"//common:type",
173+
"//common:value",
174174
"//compiler",
175175
"//compiler:compiler_factory",
176176
"//compiler:standard_library",
177-
"//eval/public:activation",
178-
"//eval/public:activation_bind_helper",
179-
"//eval/public:builtin_func_registrar",
180-
"//eval/public:cel_expr_builder_factory",
181-
"//eval/public:cel_expression",
182-
"//eval/public:cel_options",
183-
"//eval/public:cel_value",
184177
"//internal:status_macros",
178+
"//runtime",
179+
"//runtime:activation",
180+
"//runtime:bind_proto_to_activation",
181+
"//runtime:function_adapter",
182+
"//runtime:runtime_builder",
183+
"//runtime:runtime_options",
184+
"//runtime:standard_runtime_builder_factory",
185185
"@com_google_absl//absl/status",
186186
"@com_google_absl//absl/status:statusor",
187187
"@com_google_absl//absl/strings",
188-
"@com_google_cel_spec//proto/cel/expr:checked_cc_proto",
188+
"@com_google_absl//absl/types:optional",
189189
"@com_google_googleapis//google/rpc/context:attribute_context_cc_proto",
190190
"@com_google_protobuf//:protobuf",
191191
],
@@ -270,13 +270,15 @@ cc_library(
270270
deps = [
271271
":network_functions",
272272
"//checker:validation_result",
273+
"//common:ast",
273274
"//common:decl",
274275
"//common:minimal_descriptor_pool",
275276
"//common:type",
276277
"//common:value",
277278
"//compiler",
278279
"//compiler:compiler_factory",
279280
"//compiler:standard_library",
281+
"//internal:status_macros",
280282
"//runtime",
281283
"//runtime:activation",
282284
"//runtime:runtime_builder",

0 commit comments

Comments
 (0)